fix(nodebuilder/p2p): remove prepended v against detected semantic version (#3547)

Author: ramin

nodebuilder/node/buildInfo.go

@@ -32,7 +32,7 @@ func (b *BuildInfo) GetSemanticVersion() string {
 		return emptyValue
 	}
 
-	return fmt.Sprintf("v%s", b.SemanticVersion)
+	return b.SemanticVersion
 }
 
 func (b *BuildInfo) CommitShortSha() string {

nodebuilder/node/buildinfo_test.go

@@ -29,11 +29,17 @@ func TestGetSemanticVersion(t *testing.T) {
 		{
 			name: "Non-empty Semantic Version",
 			buildInfo: BuildInfo{
-				SemanticVersion: "1.2.3",
+				SemanticVersion: "v1.2.3",
 			},
 			expectedVersion: "v1.2.3",
 		},
-		// Add more test cases as needed
+		{
+			name: "Non-empty Semantic Version without v prefix",
+			buildInfo: BuildInfo{
+				SemanticVersion: "1.2.3",
+			},
+			expectedVersion: "1.2.3",
+		},
 	}
 
 	for _, tc := range tests {

nodebuilder/p2p/host_test.go

@@ -20,7 +20,7 @@ func TestUserAgent(t *testing.T) {
 			tp:       node.Full,
 			expected: "celestia-node/testnet/full/v1.0.0/abcdefg",
 			build: &node.BuildInfo{
-				SemanticVersion: "1.0.0",
+				SemanticVersion: "v1.0.0",
 				LastCommit:      "abcdefg",
 			},
 		},
@@ -30,7 +30,7 @@ func TestUserAgent(t *testing.T) {
 			expected: "celestia-node/mainnet/light/v1.0.0/abcdefg",
 			tp:       node.Light,
 			build: &node.BuildInfo{
-				SemanticVersion: "1.0.0",
+				SemanticVersion: "v1.0.0",
 				LastCommit:      "abcdefg",
 			},
 		},