[Feature Request]: allow user to set account sequence

[jcstein]

Implementation ideas

Users (including myself) have reported that they are hitting account sequence errors in posting blobs using celestia-node. The workaround for this is to set the correct account sequence. While it is possible to set the account sequence in celestia-app's binary, it isn't possible with celestia-node.

This feature's implementation would allow the user to send a transaction using celestia-node with a custom account sequence.

[distractedm1nd]

We could maybe do this for state.SubmitPayForBlob but definitely not blob module. This functionality is technically already supported via SubmitTx no?

[jcstein]

the only param I see is the data on state.SubmitTx?

[jcstein]

I don't think this is possible either on other methods, based on some testing I'm doing with the CLI at the moment.

celestia state delegate celestiavaloper1ukk0l6ce58zq3snad5vn24vy7pdk9r8hva6nz9 1 10000 100000 --node.store $NODE_STORE
{
  "result": "rpc error: code = Unknown desc = timed out waiting for tx to be included in a block"
}

celestia state delegate celestiavaloper1ukk0l6ce58zq3snad5vn24vy7pdk9r8hva6nz9 1000 10000 100000 --node.store $NODE_STORE
{
  "result": {
    "txhash": "497CA6B400C9040A3771D4D63A64EAD2C6DCCD481975D4719A33F49EA53A1676",
    "codespace": "sdk",
    "code": 32,
    "raw_log": "account sequence mismatch, expected 624, got 623: incorrect account sequence",
    "logs": null,
    "gas_wanted": 100000,
    "gas_used": 46383,
    "events": null
  }
}

celestia state delegate celestiavaloper1ukk0l6ce58zq3snad5vn24vy7pdk9r8hva6nz9 1000 10000 100000 --node.store $NODE_STORE --help
Sends a user's liquid tokens to a validator for delegation.

Usage:
  celestia state delegate [valAddress] [amount] [fee] [gasLimit] [flags]

Flags:
  -h, --help   help for delegate

Global Flags:
      --node.store string   The path to root/home directory of your Celestia Node Store
      --token string        Authorization token
      --url string          Request URL (default "http://localhost:26658")

[jcstein]

How would a user submit multiple blobs in the same block with blob.Submit or state.SubmitPayForBlobs?

[mindstyle85]

this would be really good to have, since we already saw one case where his actual vs expected sequence was not the same (due to cosmos ofc, its known this can happen), but since he was using just the da node for that, he had no way to reset it (would either require a restart of the rpc he used or import to app and use the --sequence flag)

[jcstein]

yeah, i also want to make sure the documentation that says it is possible, is actually possible. at version v0.13.0 i cannot figure out how to set account sequence through celestia-node

[bkolad]

My observation:

While submitting blobs one after another using the blob_submit(&self, blobs: &[Blob], opts: SubmitOptions) -> Result<u64, Error>, I encountered errors related to incorrect account nonce. It appears that there might be a race condition between requests. I initially assumed that the synchronization would be managed internally since the method takes &self. After wrapping the client with a Mutex, the issue disappeared, but it might be matter of timing.

[Wondertan]

The account sequence(nounce) is not managed smart enough in the node and this is the core issue here.

We could enable account sequence control for our users, but we would then outsource the complexity away, forcing every user to manage nounce on their own. Instead, we should abstract the complexity and simplify life for our users.

cc @cmwaters

[jcstein]

so how does one do this either on celestia-node or celestia-app? that's the thing i cannot figure out

[Wondertan]

Users (including myself) have reported that they are hitting account sequence errors in posting blobs using celestia-node. The workaround for this is to set the correct account sequence.

The root issue here is the lack of smarts around nounces. Once we have them, your issue disappears, and setting the account sequence won't be necessary on the node side.

so how does one do this either on celestia-node or celestia-app?

So, one wouldn't need to do it on the celestia-node side in the first place.

[jcstein]

will it allow someone to submit multiple transactions from the same account in one block? like described in this section

[rootulp]

Relevant: celestiaorg/celestia-app#3196 which improved nonce handling for the celestia-app signer (in the user package). AFAICT celestia-node doesn't use the celestia-app user package yet but celestia-node is considering migrating to it (see #2650).

[Wondertan]

will it allow someone to submit multiple transactions from the same account in one block?

Yes in case both transactions turn to be valid. If one of them is invalid, things might be a bit more complicated.