Migrated build logic to cmd/info.go
#1146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
…-next-to-version-command-into-separate-file
renaynay
reviewed
Sep 28, 2022
There was a problem hiding this comment.
Hi @0xJepsen thank you for your contribution!
Two things:
- While the issue is a bit unclear about this (and it's a bit old, so sorry for that!), there is no compelling reason to have 2 different commands for outputting version info + build info, so let's keep them together under
versionCmdand remove thebuildInfocommand. - Let's still move the version command out of the
cmd/celestiainto thecmdpackage
|
Also, the version command should still be available on the root command, not as a subcommand of |
|
Closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #347
Would it make sense to turn it into an info flag?
Or would it make more sense to add as a command in
init.go