Incorrect usage of CELESTIA_HOME

[adlerjohn]

The behavior of CELESTIA_HOME is incorrect. Currently, celestia-node files are placed directly into $CELESTIA_HOME/:

celestia-node/nodebuilder/store.go

Lines 190 to 193 in 26267c7

	home := os.Getenv("CELESTIA_HOME")
	if home != "" {
	return home, nil
	}

celestia-app on the other hand places files in $CELESTIA_HOME/.celestia-app:
https://github.com/celestiaorg/celestia-app/blob/a8b76b3b9ebaef8bbc89b7c0c293390d74359433/app/init.go#L16-L22

Behavior should be changed to similarly place files in a subdirectory.

[Wondertan]

It's a correct usage of CELESTIA_HOME. This env var is not meant to be used as directory to keep both app and node, but node only. The app should define their own CELESTIA_APP_HOME instead and use it to hold the data. Once we merge the binaries, we may also merge the homepaths.

Also see #3759

[Wondertan]

@adlerjohn agreed in sync and we moved this issue to celestiaorg/celestia-app#4532