refactor: return byzErr for clarity (#351)

rootulp · web-flow · commit a71c6b564c45 · 2025-04-30T00:43:26.000+02:00
Closes #350 This code change is strictly for clarity and it should behave identically to before. These tests still pass: 1. https://github.com/rootulp/rsmt2d/blob/fe785dafe00a1cc6cbdd346be1bd01fd193f758e/extendeddatacrossword_test.go#L185 2. https://github.com/rootulp/rsmt2d/blob/fe785dafe00a1cc6cbdd346be1bd01fd193f758e/extendeddatacrossword_test.go#L346 cc: @odeke-em
diff --git a/extendeddatacrossword.go b/extendeddatacrossword.go
@@ -155,6 +155,7 @@ func (eds *ExtendedDataSquare) solveCrosswordRow(
 		var byzErr *ErrByzantineData
 		if errors.As(err, &byzErr) {
 			byzErr.Shares = shares
+			return false, false, byzErr
 		}
 		return false, false, err
 	}
@@ -229,6 +230,7 @@ func (eds *ExtendedDataSquare) solveCrosswordCol(
 		var byzErr *ErrByzantineData
 		if errors.As(err, &byzErr) {
 			byzErr.Shares = shares
+			return false, false, byzErr
 		}
 		return false, false, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ func (eds *ExtendedDataSquare) solveCrosswordRow(`
`155`	`155`	`var byzErr *ErrByzantineData`
`156`	`156`	`if errors.As(err, &byzErr) {`
`157`	`157`	`byzErr.Shares = shares`
	`158`	`+ return false, false, byzErr`
`158`	`159`	`}`
`159`	`160`	`return false, false, err`
`160`	`161`	`}`
`@@ -229,6 +230,7 @@ func (eds *ExtendedDataSquare) solveCrosswordCol(`
`229`	`230`	`var byzErr *ErrByzantineData`
`230`	`231`	`if errors.As(err, &byzErr) {`
`231`	`232`	`byzErr.Shares = shares`
	`233`	`+ return false, false, byzErr`
`232`	`234`	`}`
`233`	`235`	`return false, false, err`
`234`	`236`	`}`