Skip to content

Commit 9b54b95

Browse files
committed
log,core,dnsx: m comments
1 parent f626c9b commit 9b54b95

3 files changed

Lines changed: 3 additions & 1 deletion

File tree

intra/core/p2est.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ var _ P2QuantileEstimator = (*p2)(nil)
4343

4444
// NewP50Estimator returns a new P50 (median) estimator.
4545
func NewP50Estimator(ctx context.Context) *p2 {
46-
// calibrate: go.dev/play/p/Ry1i61XqzgB
46+
// calibrate: go.dev/play/p/1Gzn6m4GweJ
4747
// 31 worked best amid wild latency fluctuations
4848
// using 11 for lower overhead; 5 is the default
4949
return NewP2QuantileEstimator(ctx, 11, 0.5)

intra/dnsx/transport.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1338,6 +1338,7 @@ func (r *resolver) chooseOne(chooseRandom bool, ids ...string) (theone string) {
13381338
}
13391339
r.RUnlock()
13401340

1341+
// TODO: prefer proxy DNS (wg) when available
13411342
best, preferred, recoverables, errored, ended := Categorize(trs)
13421343
if settings.Debug {
13431344
defer func() {

intra/log/ring.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ type ring[T any] struct {
2626
// NewRing creates a new ring buffer with the given capacity (256 if <= 1).
2727
// evict must be light as it is called for each element displaced by a push, under contention.
2828
func newRing[T any](ctx context.Context, capacity int, evict func(T)) *ring[T] {
29+
// go.dev/play/p/8QUZWqcG5oP
2930
if evict == nil {
3031
evict = func(T) {}
3132
}

0 commit comments

Comments
 (0)