is the return type of with_child_span/3 correct?

[dvic]

My understanding of Erlang is limited, but is the typespec of with_child_span/3 correct in terms of its return type (opencensus:maybe(opencensus:span_ctx())? The return type should be whatever the function returns right?

[dvic]

As a reference, here are the relevant lines:

opencensus-erlang/src/ocp.erl

Lines 145 to 154 in 7fb276f

	-spec with_child_span(unicode:unicode_binary(), opencensus:attributes(), fun()) -> maybe(opencensus:span_ctx()).
	with_child_span(Name, Attributes, Fun) ->
	CurrentSpanCtx = current_span_ctx(),
	NewSpanCtx = oc_trace:start_span(Name, CurrentSpanCtx, #{attributes => Attributes}),
	with_span_ctx(NewSpanCtx),
	try Fun()
	after
	oc_trace:finish_span(current_span_ctx()),
	with_span_ctx(CurrentSpanCtx)
	end.

[tsloughter]

Yea, the spec should be the return of the fun(), like we do in Otel's with_span, https://github.com/open-telemetry/opentelemetry-erlang/blob/main/apps/opentelemetry_api/src/otel_tracer.erl#L44 and https://github.com/open-telemetry/opentelemetry-erlang/blob/main/apps/opentelemetry_api/src/otel_tracer.erl#L67

[dvic]

Thanks, I've opened a PR, not sure if I got it right 😅