Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit 7e6c5d7

Browse files
author
JBD
authored
Add Jaeger support to README and fix links (#383)
1 parent 1414293 commit 7e6c5d7

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

README.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ Currently, OpenCensus supports:
3030

3131
* [Prometheus][exporter-prom] for stats
3232
* [OpenZipkin][exporter-zipkin] for traces
33-
* Stackdriver [Monitoring][exporter-sdstats] and [Trace][exporter-sdtrace]
33+
* Stackdriver [Monitoring][exporter-stackdriver] and [Trace][exporter-stackdriver]
34+
* [Jaeger][exporter-jaeger] for traces
3435

3536
## Tags
3637

@@ -255,7 +256,7 @@ An example logger exporter is below:
255256

256257
type exporter struct{}
257258

258-
func (e *exporter) Export(vd *stats.ViewData) {
259+
func (e *exporter) ExportView(vd *stats.ViewData) {
259260
log.Println(vd)
260261
}
261262

@@ -267,8 +268,8 @@ func (e *exporter) Export(vd *stats.ViewData) {
267268

268269
[embedmd]:# (trace.go startend)
269270
```go
270-
ctx = trace.StartSpan(ctx, "your choice of name")
271-
defer trace.EndSpan(ctx)
271+
ctx, span := trace.StartSpan(ctx, "your choice of name")
272+
defer span.End()
272273
```
273274

274275
More tracing examples are coming soon...
@@ -314,6 +315,6 @@ A screenshot of the CPU profile from the program above:
314315
[newtags-replace-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap--Replace
315316

316317
[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/prometheus
317-
[exporter-sdstats]: https://godoc.org/go.opencensus.io/exporter/stackdriver
318+
[exporter-stackdriver]: https://godoc.org/go.opencensus.io/exporter/stackdriver
318319
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/zipkin
319-
[exporter-sdtrace]: https://godoc.org/go.opencensus.io/exporter/trace/stackdriver
320+
[exporter-jaeger]: https://godoc.org/go.opencensus.io/exporter/jaeger

internal/readme/source.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ Currently, OpenCensus supports:
3030

3131
* [Prometheus][exporter-prom] for stats
3232
* [OpenZipkin][exporter-zipkin] for traces
33-
* Stackdriver [Monitoring][exporter-sdstats] and [Trace][exporter-sdtrace]
33+
* Stackdriver [Monitoring][exporter-stackdriver] and [Trace][exporter-stackdriver]
34+
* [Jaeger][exporter-jaeger] for traces
3435

3536
## Tags
3637

@@ -178,7 +179,7 @@ A screenshot of the CPU profile from the program above:
178179
[newtags-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap
179180
[newtags-replace-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap--Replace
180181

181-
[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/stats/prometheus
182-
[exporter-sdstats]: https://godoc.org/go.opencensus.io/exporter/stats/stackdriver
183-
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/trace/zipkin
184-
[exporter-sdtrace]: https://godoc.org/go.opencensus.io/exporter/trace/stackdriver
182+
[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/prometheus
183+
[exporter-stackdriver]: https://godoc.org/go.opencensus.io/exporter/stackdriver
184+
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/zipkin
185+
[exporter-jaeger]: https://godoc.org/go.opencensus.io/exporter/jaeger

0 commit comments

Comments
 (0)