Redis integration

[sciurus]

It would be helpful if opensensus-python automatically traced redis-py. Datadog's implementation is here.

[ewhauser]

I've adapted opentracing's Python implementation and it is available in our fork: https://github.com/dronedeploy/opencensus-python/blob/master/opencensus/trace/ext/redis/trace.py

[odeke-em]

Hello @sciurus, thank you for filing this issue! Hello @ewhauser too.

So there is already at https://opencensus.io/integrations/redis/python/redispy/ and it provides traces and stats, please check it out :)

[ewhauser]

This wasn’t available when this issue was created. A bit weird to say “so there is already”

[odeke-em]

This wasn’t available when this issue was created. A bit weird to say “so there is already”

In deed but yes and no. I started that work in October 2018 and but didn't have time to publish it until February 2019. Anyways it is now available.

Please evaluate and when ready we can close this issue. Thanks.

[odeke-em]

Actually @ewhauser, perhaps I sounded too dismissive earlier on, my apologies. On thinking about it again, I like your update which does monkey-patching and perhaps that is an even more appropriate solution than the wrapping that I made. Let's evaluate both solutions and meet in the middle for what to include in opencensus.ext.redis. I am totally happy with going whichever solution, plus it would be great to get your contribution in here.

[ewhauser]

To be fair, I didn't really write too much of that integration - it's a port of the OpenTracing code. I'm not really concerned about which direction you decide to go, but happen to help in any way I can.

[reyang]

@ewhauser would you be willing to contribute your implementation to https://github.com/census-instrumentation/opencensus-python/tree/master/contrib?

I can help to review and get it merged.

[reyang]

@tjzo You've mentioned this in #548 (comment).
I would need your help to review and give feedback if @ewhauser is willing to contribute on this.

[ewhauser]

Yes, happy to contribute.

…

On Thu, Apr 4, 2019 at 4:24 PM Reiley Yang ***@***.***> wrote: @tjzo <https://github.com/tjzo> You've mentioned this in #548 (comment) <#548 (comment)> . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#404 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIBPeGDhirrGKaw909iXX9NLO8NvS7xks5vdl-UgaJpZM4YreHz> .