fix: saturate vaultInvestOrders and vaultRedeemOrders at zero (#261)

Author: filo87

src/helpers/bigintMath.ts

@@ -0,0 +1,17 @@
+/**
+ * Returns the minimum value from a list of bigints.
+ * @param values - The list of bigints to find the minimum value of.
+ * @returns The minimum value from the list of bigints.
+ */
+export function bigintMin(...values: bigint[]) {
+  return values.reduce((min, value) => (value < min ? value : min), values[0] ?? 0n);
+}
+
+/**
+ * Returns the maximum value from a list of bigints.
+ * @param values - The list of bigints to find the maximum value of.
+ * @returns The maximum value from the list of bigints.
+ */
+export function bigintMax(...values: bigint[]) {
+  return values.reduce((max, value) => (value > max ? value : max), values[0] ?? 0n);
+}

src/services/VaultInvestOrderService.ts

@@ -2,6 +2,7 @@ import { VaultInvestOrder } from "ponder:schema";
 import type { Event } from "ponder:registry";
 import { Service, mixinCommonStatics } from "./Service";
 import { serviceLog } from "../helpers/logger";
+import { bigintMax } from "../helpers/bigintMath";
 
 /**
  * Service class for managing VaultInvestOrder entities.
@@ -23,8 +24,9 @@ export class VaultInvestOrderService extends mixinCommonStatics(
    */
   public depositRequest(requestedAssetsAmount: bigint) {
     serviceLog(`Adding requested assets amount ${requestedAssetsAmount} to vault invest order`);
-    this.data.requestedAssetsAmount =
-      (this.data.requestedAssetsAmount ?? 0n) + requestedAssetsAmount;
+    const previousRequestedAssetsAmount = this.data.requestedAssetsAmount ?? 0n;
+    const newRequestedAssetsAmount = previousRequestedAssetsAmount + requestedAssetsAmount;
+    this.data.requestedAssetsAmount = newRequestedAssetsAmount;
     return this;
   }
 
@@ -35,8 +37,9 @@ export class VaultInvestOrderService extends mixinCommonStatics(
    */
   public claimableDeposit(claimableAssetsAmount: bigint) {
     serviceLog(`Adding claimable assets amount ${claimableAssetsAmount} to vault invest order`);
-    this.data.claimableAssetsAmount =
-      (this.data.claimableAssetsAmount ?? 0n) + claimableAssetsAmount;
+    const previousClaimableAssetsAmount = this.data.claimableAssetsAmount ?? 0n;
+    const newClaimableAssetsAmount = previousClaimableAssetsAmount + claimableAssetsAmount;
+    this.data.claimableAssetsAmount = newClaimableAssetsAmount;
     return this;
   }
 
@@ -47,8 +50,12 @@ export class VaultInvestOrderService extends mixinCommonStatics(
    */
   public deposit(assetsAmount: bigint) {
     serviceLog(`Depositing assets amount ${assetsAmount} into vault invest order`);
-    this.data.requestedAssetsAmount = (this.data.requestedAssetsAmount ?? 0n) - assetsAmount;
-    this.data.claimableAssetsAmount = (this.data.claimableAssetsAmount ?? 0n) - assetsAmount;
+    const previousRequestedAssetsAmount = this.data.requestedAssetsAmount ?? 0n;
+    const newRequestedAssetsAmount = previousRequestedAssetsAmount - assetsAmount;
+    this.data.requestedAssetsAmount = bigintMax(newRequestedAssetsAmount, 0n);
+    const previousClaimableAssetsAmount = this.data.claimableAssetsAmount ?? 0n;
+    const newClaimableAssetsAmount = previousClaimableAssetsAmount - assetsAmount;
+    this.data.claimableAssetsAmount = bigintMax(newClaimableAssetsAmount, 0n);
     return this;
   }
 

src/services/VaultRedeemOrderService.ts

@@ -2,6 +2,7 @@ import type { Event } from "ponder:registry";
 import { VaultRedeemOrder } from "ponder:schema";
 import { Service, mixinCommonStatics } from "./Service";
 import { serviceLog } from "../helpers/logger";
+import { bigintMax } from "../helpers/bigintMath";
 
 /**
  * Service class for managing VaultRedeem entities.
@@ -23,8 +24,9 @@ export class VaultRedeemOrderService extends mixinCommonStatics(
    */
   public redeemRequest(requestedSharesAmount: bigint) {
     serviceLog(`Adding requested shares amount ${requestedSharesAmount} to vault redeem order`);
-    this.data.requestedSharesAmount =
-      (this.data.requestedSharesAmount ?? 0n) + requestedSharesAmount;
+    const previousRequestedSharesAmount = this.data.requestedSharesAmount ?? 0n;
+    const newRequestedSharesAmount = previousRequestedSharesAmount + requestedSharesAmount;
+    this.data.requestedSharesAmount = newRequestedSharesAmount;
     return this;
   }
 
@@ -35,8 +37,9 @@ export class VaultRedeemOrderService extends mixinCommonStatics(
    */
   public claimableRedeem(claimableSharesAmount: bigint) {
     serviceLog(`Adding claimable shares amount ${claimableSharesAmount} to vault redeem order`);
-    this.data.claimableSharesAmount =
-      (this.data.claimableSharesAmount ?? 0n) + claimableSharesAmount;
+    const previousClaimableSharesAmount = this.data.claimableSharesAmount ?? 0n;
+    const newClaimableSharesAmount = previousClaimableSharesAmount + claimableSharesAmount;
+    this.data.claimableSharesAmount = newClaimableSharesAmount;
     return this;
   }
 
@@ -47,8 +50,12 @@ export class VaultRedeemOrderService extends mixinCommonStatics(
    */
   public redeem(sharesAmount: bigint) {
     serviceLog(`Redeeming shares amount ${sharesAmount} from vault redeem order`);
-    this.data.requestedSharesAmount = (this.data.requestedSharesAmount ?? 0n) - sharesAmount;
-    this.data.claimableSharesAmount = (this.data.claimableSharesAmount ?? 0n) - sharesAmount;
+    const previousRequestedSharesAmount = this.data.requestedSharesAmount ?? 0n;
+    const newRequestedSharesAmount = previousRequestedSharesAmount - sharesAmount;
+    this.data.requestedSharesAmount = bigintMax(newRequestedSharesAmount, 0n);
+    const previousClaimableSharesAmount = this.data.claimableSharesAmount ?? 0n;
+    const newClaimableSharesAmount = previousClaimableSharesAmount - sharesAmount;
+    this.data.claimableSharesAmount = bigintMax(newClaimableSharesAmount, 0n);
     return this;
   }