ci: Test and fix prod deploy (#2640)

* Test and fix prod deploy
* Remove useless Readme
* Update readme with new workflow files

Author: gpmayorga

.github/workflows/README.md

@@ -7,15 +7,21 @@ Each workflow represents a different trigger rather than a different "way of bui
 ```
 .github/workflows
 ├── centrifuge-app.yml -> triggers on PR or push to main (only changes to centrifuge-app components)
+├── centrifuge-app-countercheck.yml -> validates centrifuge-app deployment
 ├── demo-deploys.yml -> manual triggered deployment (deploys all)
+├── dev-n-ffprod-deploys.yml -> handles development and feature-flag production deployments
+├── deploy_all.yml -> orchestrates deployment of all components
+├── e2e.yml -> runs end-to-end tests 
 ├── fabric.yml -> builds on PR or push to main (only changes to fabric/)
-├── faucet-api.yml. Deploys 
+├── faucet-api.yml -> handles faucet API deployments
 ├── npm-publish.yml -> always manual from main
 ├── onboarding-api.yml -> triggers on PR or push to main (only changes to onboarding-api/)
+├── onboarding-api-countercheck.yml -> validates onboarding-api deployment
 ├── pinning-api.yml -> triggers on PR or push to main (only changes to pinning-api/)
-├── pre-prod-deploys.yml -> Manually deploy from main to Altair & Pre-prod. Always manual. Requires approval
+├── pinning-api-countercheck.yml -> validates pinning-api deployment
 ├── prepare-pr.yml -> Deploy functions for all PRs. Delete PR artifacts when closed
-└── prod-deploys.yml -> Move artifacts from pre-prod. Always manual. Requires approval
+├── prod-deploy.yml -> Fetches artifacts form an existing release
+└── staging-deploy.yml -> Builds & Uploads artifacts to a release, then deploys to staging and ff-prod
 ```
 ### Supporting actions
 ```

.github/workflows/prod-deploy.yml

@@ -1,5 +1,8 @@
 name: Promote staging to PROD
 on:
+  pull_request:
+    paths:
+      - .github/workflows/prod-deploy.yml # For testing changes, won't deploy to prod
   release:
     types:
       - released
@@ -14,31 +17,53 @@ concurrency:
   cancel-in-progress: false
 
 jobs:
-  deploy-app:
-    name: app-prod-deploy
+  get-release-artifacts:
+    name: download-${{ matrix.artifact.name }}
+    runs-on: ubuntu-latest
     permissions:
       contents: 'read'
       id-token: 'write'
-    runs-on: ubuntu-latest
-    environment: production
+    strategy:
+      matrix:
+        artifact:
+          - name: webpack
+            path: centrifuge-app/build/
+          - name: pinning-api
+            path: pinning-api/dist/
+          - name: onboarding-api
+            path: onboarding-api/dist/
     steps:
       - uses: dsaltares/fetch-gh-release-asset@aa2ab1243d6e0d5b405b973c89fa4d06a2d0fff7 # v1.1.2
         with:
           repo: 'centrifuge/apps'
           version: ${{ github.event_name == 'release' && github.event.release.id || format('tags/centrifuge-app/{0}', inputs.tag) }}
-          file: "webpack.zip"
-          regex: true
+          # version: 'tags/centrifuge-app/v2.83.4' # <- uncomment thisfor testing
+          file: "${{ matrix.artifact.name }}.zip"
+          target: "${{ matrix.artifact.name }}.zip"
 
       - name: Unzip release files
+        env:
+          ZIPFILE: ${{ matrix.artifact.name }}
         run: |
-          unzip webpack.zip -d webpack 1> /dev/null
-      # Unzipped folder structure is webpack/centrifuge-app/build/inde.js
+          ls -la
+          unzip $ZIPFILE 1> /dev/null
+          ls -la
       
       - name: Upload webpack files
         uses: actions/upload-artifact@v4
         with:
-          name: webpack
-          path: webpack/centrifuge-app/build/
+          name: ${{ matrix.artifact.name }}
+          path: ${{ matrix.artifact.path }}
+  
+  deploy-app:
+    name: app-prod-deploy
+    permissions:
+      contents: 'read'
+      id-token: 'write'
+    runs-on: ubuntu-latest
+    environment: production
+    if: ${{ github.event_name != 'pull_request' }}
+    steps:
 
       - name: Checkout
         uses: actions/checkout@v4
@@ -60,6 +85,7 @@ jobs:
     name: ${{ matrix.function.name }}-prod-deploy
     runs-on: ubuntu-latest
     environment: production
+    if: ${{ github.event_name != 'pull_request' }}
     permissions:
       contents: 'read'
       id-token: 'write'
@@ -75,24 +101,6 @@ jobs:
             service_account: ${{ vars.ONBOARDING_FUNCT_SA }}
     steps:
 
-      - uses: dsaltares/fetch-gh-release-asset@aa2ab1243d6e0d5b405b973c89fa4d06a2d0fff7 # v1.1.2
-        with:
-          repo: 'centrifuge/apps'
-          version: ${{ github.event_name == 'release' && github.event.release.id || format('tags/centrifuge-app/{0}', inputs.tag) }}
-          file: "${{ matrix.function.name }}.zip"
-          regex: true
-
-      - name: Unzip release files
-        run: |
-          unzip ${{ matrix.function.name }}.zip 1> /dev/null
-      # Unzipped folder structure is ${{ matrix.function.name }}/dist/index.js
-
-      - name: Upload function files
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ matrix.function.name }}
-          path: ${{ matrix.function.name }}/dist/
-          
       - name: Checkout
         uses: actions/checkout@v4
         with: