Add proxy types (#292)

* types: Add entities from the keystore pallet

* keystore: Change enum to uint alias

* account_id: Add helper methods

* account_id: Add equal method

* proxy: Add proxy storage types

* proxy: Add name and value maps for proxy type

* types: Check bytes length when creating account ID

* types: Add more tests

* proxy: Add anchor management proxy type

* proxy: Implement encode/decode for ProxyStorageEntry and ProxyDefinition

* keystore: Add keystore events

* types: Rename uniques pallet vars

* tests: Fix proxy tests

* types: Add generic option

* proxy: Update proxy types

* types: Use [4]U8 for module error

* metadata: Use [4]U8 for metadata.FindError

* types: Use U128 for item IDs for uniques pallet events

* types: Export testing functions

* types: Fix lint errors

* option: Add HasValue method

* client: Add extra check for closed connections

* header: Remove OptionBlockNumber

Author: cdamian

client/client.go

@@ -14,8 +14,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-//go:generate mockery --name Client
-
 package client
 
 import (
@@ -25,8 +23,11 @@ import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/config"
 	gethrpc "github.com/centrifuge/go-substrate-rpc-client/v4/gethrpc"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
+//go:generate mockery --name Client
+
 type Client interface {
 	// Call makes the call to RPC method with the provided args
 	// args must be encoded in the format RPC understands
@@ -73,7 +74,7 @@ func CallWithBlockHash(c Client, target interface{}, method string, blockHash *t
 		}
 		return nil
 	}
-	hexHash, err := types.Hex(*blockHash)
+	hexHash, err := codec.Hex(*blockHash)
 	if err != nil {
 		return err
 	}

gethrpc/client.go

@@ -480,17 +480,33 @@ func (c *Client) send(ctx context.Context, op *requestOp, msg interface{}) error
 }
 
 func (c *Client) write(ctx context.Context, msg interface{}) error {
+	if err := c.checkWriteConn(ctx); err != nil {
+		return err
+	}
+
+	if err := c.writeConn.Write(ctx, msg); err != nil {
+		c.writeConn = nil
+		return err
+	}
+
+	return nil
+}
+
+func (c *Client) checkWriteConn(ctx context.Context) error {
 	// The previous write failed. Try to establish a new connection.
 	if c.writeConn == nil {
-		if err := c.reconnect(ctx); err != nil {
-			return err
-		}
+		return c.reconnect(ctx)
 	}
-	err := c.writeConn.Write(ctx, msg)
-	if err != nil {
-		c.writeConn = nil
+
+	// Extra check to ensure that connection is not closed.
+	select {
+	case <-c.writeConn.Closed():
+		return c.reconnect(ctx)
+	case <-ctx.Done():
+		return ctx.Err()
+	default:
+		return nil
 	}
-	return err
 }
 
 func (c *Client) reconnect(ctx context.Context) error {

main_test.go

@@ -25,6 +25,7 @@ import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/config"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/signature"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
 func Example_simpleConnect() {
@@ -132,7 +133,7 @@ func Example_listenToBalanceChange() {
 			}
 
 			var acc types.AccountInfo
-			if err = types.Decode(chng.StorageData, &acc); err != nil {
+			if err = codec.Decode(chng.StorageData, &acc); err != nil {
 				panic(err)
 			}
 
@@ -295,7 +296,7 @@ func Example_displaySystemEvents() {
 		set := <-sub.Chan()
 		// inner loop for the changes within one of those notifications
 		for _, chng := range set.Changes {
-			if !types.Eq(chng.StorageKey, key) || !chng.HasStorageData {
+			if !codec.Eq(chng.StorageKey, key) || !chng.HasStorageData {
 				// skip, we are only interested in events with content
 				continue
 			}

rpc/author/pending_extrinsics.go

@@ -18,6 +18,7 @@ package author
 
 import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
 // PendingExtrinsics returns all pending extrinsics, potentially grouped by sender
@@ -30,7 +31,7 @@ func (a *author) PendingExtrinsics() ([]types.Extrinsic, error) {
 
 	xts := make([]types.Extrinsic, len(res))
 	for i, re := range res {
-		err = types.DecodeFromHex(re, &xts[i])
+		err = codec.DecodeFromHex(re, &xts[i])
 		if err != nil {
 			return nil, err
 		}

rpc/author/submit_and_watch_extrinsic.go

@@ -23,6 +23,7 @@ import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/config"
 	gethrpc "github.com/centrifuge/go-substrate-rpc-client/v4/gethrpc"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
 // ExtrinsicStatusSubscription is a subscription established through one of the Client's subscribe methods.
@@ -68,7 +69,7 @@ func (a *author) SubmitAndWatchExtrinsic(xt types.Extrinsic) (*ExtrinsicStatusSu
 
 	c := make(chan types.ExtrinsicStatus)
 
-	enc, err := types.EncodeToHex(xt)
+	enc, err := codec.EncodeToHex(xt)
 	if err != nil {
 		return nil, err
 	}

rpc/author/submit_extrinsic.go

@@ -16,11 +16,14 @@
 
 package author
 
-import "github.com/centrifuge/go-substrate-rpc-client/v4/types"
+import (
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
+)
 
 // SubmitExtrinsic will submit a fully formatted extrinsic for block inclusion
 func (a *author) SubmitExtrinsic(xt types.Extrinsic) (types.Hash, error) {
-	enc, err := types.EncodeToHex(xt)
+	enc, err := codec.EncodeToHex(xt)
 	if err != nil {
 		return types.Hash{}, err
 	}

rpc/author/submit_extrinsic_test.go

@@ -24,6 +24,7 @@ import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/config"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/signature"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -84,7 +85,7 @@ func TestAuthor_SubmitExtrinsic(t *testing.T) {
 			continue
 		}
 
-		hex, err := types.Hex(res)
+		hex, err := codec.Hex(res)
 		assert.NoError(t, err)
 		assert.NotEmpty(t, hex)
 		break

rpc/offchain/get_local_storage.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
 // StorageKind ...
@@ -45,7 +46,7 @@ func (c *offchain) LocalStorageGet(kind StorageKind, key []byte) (*types.Storage
 		return nil, nil
 	}
 
-	b, err := types.HexDecodeString(res)
+	b, err := codec.HexDecodeString(res)
 	if err != nil {
 		return nil, err
 	}

rpc/state/get_child_keys.go

@@ -19,6 +19,7 @@ package state
 import (
 	"github.com/centrifuge/go-substrate-rpc-client/v4/client"
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 )
 
 // GetChildKeys retreives the keys with the given prefix of a specific child storage
@@ -42,7 +43,7 @@ func (s *state) getChildKeys(childStorageKey, prefix types.StorageKey, blockHash
 
 	keys := make([]types.StorageKey, len(res))
 	for i, r := range res {
-		err = types.DecodeFromHex(r, &keys[i])
+		err = codec.DecodeFromHex(r, &keys[i])
 		if err != nil {
 			return nil, err
 		}

rpc/state/get_child_keys_test.go

@@ -20,19 +20,20 @@ import (
 	"testing"
 
 	"github.com/centrifuge/go-substrate-rpc-client/v4/types"
+	"github.com/centrifuge/go-substrate-rpc-client/v4/types/codec"
 	"github.com/stretchr/testify/assert"
 )
 
-var prefix = types.NewStorageKey(types.MustHexDecodeString(mockSrv.childStorageTrieKeyHex))[:8]
+var prefix = types.NewStorageKey(codec.MustHexDecodeString(mockSrv.childStorageTrieKeyHex))[:8]
 
 func TestState_GetChildKeysLatest(t *testing.T) {
 	keys, err := testState.GetChildKeysLatest(childStorageKey, prefix)
 	assert.NoError(t, err)
-	assert.Equal(t, []types.StorageKey{types.MustHexDecodeString(mockSrv.childStorageTrieKeyHex)}, keys)
+	assert.Equal(t, []types.StorageKey{codec.MustHexDecodeString(mockSrv.childStorageTrieKeyHex)}, keys)
 }
 
 func TestState_GetChildKeys(t *testing.T) {
 	keys, err := testState.GetChildKeys(childStorageKey, prefix, mockSrv.blockHashLatest)
 	assert.NoError(t, err)
-	assert.Equal(t, []types.StorageKey{types.MustHexDecodeString(mockSrv.childStorageTrieKeyHex)}, keys)
+	assert.Equal(t, []types.StorageKey{codec.MustHexDecodeString(mockSrv.childStorageTrieKeyHex)}, keys)
 }