cleanup: move Destroy() method to journalledObject interface

VolumeGroup interface has more than 10 methods and it causes
golangci-lint to fail. Moving the `Destroy()` method to a base
interface journalledObject.

Signed-off-by: Praveen M <m.praveen@ibm.com>

Author: iPraveenParihar

internal/rbd/types/group.go

@@ -37,15 +37,15 @@ type journalledObject interface {
 
 	// GetClusterID returns the ID of the cluster of the object.
 	GetClusterID(ctx context.Context) (string, error)
+
+	// Destroy frees the resources used by the object.
+	Destroy(ctx context.Context)
 }
 
 // VolumeGroup contains a number of volumes.
 type VolumeGroup interface {
 	journalledObject
 
-	// Destroy frees the resources used by the VolumeGroup.
-	Destroy(ctx context.Context)
-
 	// GetIOContext returns the IOContext for performing librbd operations
 	// on the VolumeGroup. This is used by the rbdVolume struct when it
 	// needs to add/remove itself from the VolumeGroup.

internal/rbd/types/snapshot.go

@@ -28,9 +28,6 @@ import (
 type Snapshot interface {
 	journalledObject
 
-	// Destroy frees the resources used by the Snapshot.
-	Destroy(ctx context.Context)
-
 	// Delete removes the snapshot from the storage backend.
 	Delete(ctx context.Context) error
 

internal/rbd/types/volume.go

@@ -67,9 +67,6 @@ type Volume interface {
 	snapshottableVolume
 	csiAddonsVolume
 
-	// Destroy frees the resources used by the Volume.
-	Destroy(ctx context.Context)
-
 	// Delete removes the volume from the storage backend.
 	Delete(ctx context.Context) error
 

internal/rbd/types/volume_group_snapshot.go

@@ -29,9 +29,6 @@ import (
 type VolumeGroupSnapshot interface {
 	journalledObject
 
-	// Destroy frees the resources used by the VolumeGroupSnapshot.
-	Destroy(ctx context.Context)
-
 	// Delete removes the VolumeGroupSnapshot from the storage backend.
 	Delete(ctx context.Context) error