Prevent head requests triggering run on null, thanks to @jamesdb (#123)

Author: cesargb

src/Middlewares/MagiclinkMiddleware.php

@@ -11,14 +11,14 @@ class MagiclinkMiddleware
 {
     public function handle(Request $request, Closure $next)
     {
-        if ($request->method() === 'HEAD') {
-            return $next($request);
-        }
-
         $token = (string) $request->route('token');
 
         $magicLink = MagicLink::getValidMagicLinkByToken($token);
 
+        if ($request->method() === 'HEAD') {
+            return response()->noContent($magicLink ? 200 : 404);
+        }
+
         if (! $magicLink) {
             return $this->badResponse();
         }

tests/HttpTest.php

@@ -73,4 +73,14 @@ public function test_http_urlencode_legacy()
             ->assertStatus(200)
             ->assertSeeText('private content');
     }
+
+    public function test_http_head_request_without_valid_magiclink()
+    {
+        $magiclink = MagicLink::create(new ResponseAction(function () {
+            return 'private content';
+        }));
+
+        $this->head($magiclink->url . '-bad')
+            ->assertStatus(404);
+    }
 }