Skip to content

Commit 1e3bfd0

Browse files
committed
test: remove irrelevant checks
1 parent cd6b234 commit 1e3bfd0

File tree

3 files changed

+8
-43
lines changed

3 files changed

+8
-43
lines changed

lib/cesium_link_web/live/auth_live/index.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ defmodule CesiumLinkWeb.AuthLive.Index do
88
~H"""
99
<div class="flex min-h-screen items-center justify-center px-4 sm:px-6 lg:px-8">
1010
<div class="flex flex-col gap-8">
11-
<img src={~p"/images/cesium-link.svg"} width="260" />
11+
<img alt="cesium.link" src={~p"/images/cesium-link.svg"} width="260" />
1212
<a href={@oauth_google_url}>
1313
<.google_oauth_button />
1414
</a>

test/cesium_link_web/live/user_login_live_test.exs

+4-39
Original file line numberDiff line numberDiff line change
@@ -6,54 +6,19 @@ defmodule CesiumLinkWeb.UserLoginLiveTest do
66

77
describe "Log in page" do
88
test "renders log in page", %{conn: conn} do
9-
{:ok, _lv, html} = live(conn, ~p"/users/log_in")
9+
{:ok, _lv, html} = live(conn, ~p"/admin")
1010

11-
assert html =~ "Log in"
12-
assert html =~ "Register"
13-
assert html =~ "Forgot your password?"
11+
assert html =~ "Sign in with Google"
1412
end
1513

1614
test "redirects if already logged in", %{conn: conn} do
1715
result =
1816
conn
1917
|> log_in_user(user_fixture())
20-
|> live(~p"/users/log_in")
21-
|> follow_redirect(conn, "/")
18+
|> live(~p"/admin")
19+
|> follow_redirect(conn, "/admin/links")
2220

2321
assert {:ok, _conn} = result
2422
end
2523
end
26-
27-
describe "user login" do
28-
test "redirects if user login with valid credentials", %{conn: conn} do
29-
password = "123456789abcd"
30-
user = user_fixture(%{password: password})
31-
32-
{:ok, lv, _html} = live(conn, ~p"/users/log_in")
33-
34-
form =
35-
form(lv, "#login_form", user: %{email: user.email, password: password, remember_me: true})
36-
37-
conn = submit_form(form, conn)
38-
39-
assert redirected_to(conn) == ~p"/"
40-
end
41-
42-
test "redirects to login page with a flash error if there are no valid credentials", %{
43-
conn: conn
44-
} do
45-
{:ok, lv, _html} = live(conn, ~p"/users/log_in")
46-
47-
form =
48-
form(lv, "#login_form",
49-
user: %{email: "[email protected]", password: "123456", remember_me: true}
50-
)
51-
52-
conn = submit_form(form, conn)
53-
54-
assert Phoenix.Flash.get(conn.assigns.flash, :error) == "Invalid email or password"
55-
56-
assert redirected_to(conn) == "/users/log_in"
57-
end
58-
end
5924
end

test/cesium_link_web/user_auth_test.exs

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ defmodule CesiumLinkWeb.UserAuthTest do
2222
conn = UserAuth.log_in_user(conn, user)
2323
assert token = get_session(conn, :user_token)
2424
assert get_session(conn, :live_socket_id) == "users_sessions:#{Base.url_encode64(token)}"
25-
assert redirected_to(conn) == ~p"/"
25+
assert redirected_to(conn) == ~p"/admin/links"
2626
assert Accounts.get_user_by_session_token(token)
2727
end
2828

@@ -216,7 +216,7 @@ defmodule CesiumLinkWeb.UserAuthTest do
216216
test "redirects if user is authenticated", %{conn: conn, user: user} do
217217
conn = conn |> assign(:current_user, user) |> UserAuth.redirect_if_user_is_authenticated([])
218218
assert conn.halted
219-
assert redirected_to(conn) == ~p"/"
219+
assert redirected_to(conn) == ~p"/admin/links"
220220
end
221221

222222
test "does not redirect if user is not authenticated", %{conn: conn} do
@@ -231,7 +231,7 @@ defmodule CesiumLinkWeb.UserAuthTest do
231231
conn = conn |> fetch_flash() |> UserAuth.require_authenticated_user([])
232232
assert conn.halted
233233

234-
assert redirected_to(conn) == ~p"/users/log_in"
234+
assert redirected_to(conn) == ~p"/admin"
235235

236236
assert Phoenix.Flash.get(conn.assigns.flash, :error) ==
237237
"You must log in to access this page."

0 commit comments

Comments
 (0)