Revert stubs

Author: ivs-cetmix

cetmix_tower_yaml/models/cx_tower_yaml_mixin.py

@@ -357,25 +357,21 @@ def _queue_deferred_x2m_import(self, field, comodel, value):
         return True
 
     def _get_yaml_duplicate_reference_dict(self, ref, values):
-        """Return YAML payload when this record was already serialized in the export.
+        """Return the stub emitted when a record has already been serialized.
 
-        The collector deduplicates by (model, reference) and otherwise emits only
-        ``{"reference": ...}``. Nested one2many rows may be imported before the
-        full record exists; ``create`` still needs required scalars (e.g. ``name``).
+        The collector deduplicates by (model, reference); subsequent occurrences
+        are collapsed to a reference-only dict. Import must never attempt to create
+        from this stub — it must resolve the record by reference instead.
 
         Args:
             ref (str): Record reference.
-            values (dict): Raw values from :meth:`~odoo.models.Model.read` before
-                YAML post-processing.
+            values (dict): Raw values (unused; kept for signature compatibility
+                in case subclasses need them).
 
         Returns:
-            dict: Minimal stub safe for import when a duplicate appears in the same
-                file.
+            dict: ``{"reference": ref}`` only.
         """
-        stub = {"reference": ref}
-        if values.get("name"):
-            stub["name"] = values["name"]
-        return stub
+        return {"reference": ref}
 
     def _post_process_record_values(self, values):
         """Post process record values
@@ -732,18 +728,18 @@ def _update_or_create_related_record(
 
             # If the record does not exist, create a new one
             else:
+                if set(values.keys()) == {"reference"}:
+                    _logger.warning(
+                        "Attempted to import a record for model '%s' "
+                        "with reference "
+                        "'%s', but only the 'reference' field was provided. "
+                        "Creation will be skipped until the target record "
+                        "exists.",
+                        model._name,
+                        reference,
+                    )
+                    return False
                 if create_immediately:
-                    if set(values.keys()) == {"reference"}:
-                        _logger.warning(
-                            "Attempted to import a record for model '%s' "
-                            "with reference "
-                            "'%s', but only the 'reference' field was provided. "
-                            "Creation will be skipped until the target record "
-                            "exists.",
-                            model._name,
-                            reference,
-                        )
-                        return False
                     record = model.with_context(from_yaml=True).create(
                         model._post_process_yaml_dict_values(values)
                     )
@@ -753,20 +749,20 @@ def _update_or_create_related_record(
 
         # If there's no reference but value is a dict, create a new record
         else:
-            if create_immediately:
-                # Only 'reference' provided, no other data: do not create,
-                # just log warning
-                if set(values.keys()) == {"reference"}:
-                    _logger.warning(
-                        "Attempted to import a record for model '%s' with reference "
-                        "'%s', but only the 'reference' field was provided. "
-                        "It is possible that this record has already been imported. "
-                        "Creation will be skipped.",
-                        model._name,
-                        reference,
-                    )
-                    return False
+            # Only 'reference' provided, no other data: do not create,
+            # just log warning
+            if set(values.keys()) == {"reference"}:
+                _logger.warning(
+                    "Attempted to import a record for model '%s' with reference "
+                    "'%s', but only the 'reference' field was provided. "
+                    "It is possible that this record has already been imported. "
+                    "Creation will be skipped.",
+                    model._name,
+                    reference,
+                )
+                return False
 
+            if create_immediately:
                 record = model.with_context(from_yaml=True).create(
                     model._post_process_yaml_dict_values(values)
                 )