Detect stale Git comparisons on re-entry (#405)

* fix(git): check comparison freshness on re-entry

* test(git): wait for active comparison surface

Author: cfal

integration-tests/tests/e2e/git-comparison.test.ts

@@ -108,10 +108,18 @@ describe('Lightpanda Git comparison', () => {
 			);
 			expect(mountedRows).toBeLessThan(30);
 
+			await app.selectMainWorkspaceSurface('Chat');
+			await fixture.page.waitForSelector(
+				'[role="tabpanel"][data-workspace-surface-id="singleton:chat"][aria-hidden="false"]',
+			);
 			await writeFile(join(project, 'large.txt'), `${refreshed}\n`, 'utf8');
+			await app.selectMainWorkspaceSurface('Git');
+			await fixture.page.waitForSelector(
+				'[role="tabpanel"][data-workspace-surface-id="singleton:git"][aria-hidden="false"]',
+			);
 			await fixture.page.waitForFunction(
 				() => document.body.textContent?.includes('The Working Tree changed.'),
-				{ timeout: 25_000 },
+				{ timeout: 5_000 },
 			);
 			expect(await fixture.page.$eval('body', (element) => element.textContent)).toContain(
 				'large after marker',

web/src/lib/components/git/__tests__/git-freshness-polling.test.ts

@@ -28,7 +28,7 @@ describe('git freshness polling', () => {
 		vi.useRealTimers();
 	});
 
-	it('polls on the configured interval without an immediate first tick', () => {
+	it('polls immediately and on the configured interval', async () => {
 		vi.useFakeTimers();
 		const checkFreshness = vi.fn();
 		const documentRef = makeDocumentRef('visible');
@@ -40,11 +40,14 @@ describe('git freshness polling', () => {
 			intervalMs: 15_000,
 		});
 
-		expect(checkFreshness).not.toHaveBeenCalled();
+		await vi.runAllTicks();
+		expect(checkFreshness).toHaveBeenCalledOnce();
+		expect(checkFreshness).toHaveBeenLastCalledWith('/project');
 		vi.advanceTimersByTime(14_999);
-		expect(checkFreshness).not.toHaveBeenCalled();
+		expect(checkFreshness).toHaveBeenCalledOnce();
 		vi.advanceTimersByTime(1);
-		expect(checkFreshness).toHaveBeenCalledWith('/project');
+		expect(checkFreshness).toHaveBeenCalledTimes(2);
+		expect(checkFreshness).toHaveBeenLastCalledWith('/project');
 
 		cleanup();
 	});

web/src/lib/components/git/git-freshness-polling.ts

@@ -36,6 +36,7 @@ export function startGitFreshnessPolling({
 	return startVisibilityPolling({
 		intervalMs,
 		poll: () => checkFreshness(projectPath),
+		pollImmediately: true,
 		documentRef,
 		setIntervalFn,
 		clearIntervalFn,