Skip to content

Commit a84275c

Browse files
committed
Fixed duplicate bundlesequence_end when bundlesequence_classification not defined
Ticket: CFE-4588 Changelog: Title (cherry picked from commit ff02373)
1 parent b0f1e8f commit a84275c

1 file changed

Lines changed: 26 additions & 8 deletions

File tree

controls/def.cf

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -226,15 +226,33 @@ bundle common def
226226
if => not( isvariable( "control_agent_maxconnections" ) );
227227

228228
# Because in some versions of cfengine bundlesequence in body common
229-
# control does not support does not support iteration over data containers
230-
# we must first pick out the bundles into a shallow container that we can
231-
# then get a regular list from using getvalues().
229+
# control does not support iteration over data containers we must first
230+
# pick out the bundles into a shallow container that we can then get a
231+
# regular list from using getvalues().
232232

233-
"tbse" data => mergedata( "def.control_common_bundlesequence_end" );
234-
"bundlesequence_end" slist => getvalues( tbse );
235-
236-
"tbse" data => mergedata( "def.control_common_bundlesequence_classification" );
237-
"bundlesequence_classification" slist => getvalues( tbse );
233+
"bundlesequence_end" -> { "CFE-4855" }
234+
slist => { },
235+
if => not( isvariable( "def.control_common_bundlesequence_end") ),
236+
comment => concat( "We define an empty list so that the agent will not",
237+
" error about undefined variable when ",
238+
" def.bundlesequence_end is not defined." );
239+
"bundlesequence_end" -> { "CFE-4855" }
240+
slist => getvalues( mergedata( "def.control_common_bundlesequence_end" ) ),
241+
comment => concat( "We define bundlesequence_end from Augments if it's",
242+
" available. This allows for customization without",
243+
" modifying the vendored policy." );
244+
245+
"bundlesequence_classification" -> { "CFE-4855" }
246+
slist => { },
247+
if => not( isvariable( "def.control_common_bundlesequence_classification") ),
248+
comment => concat( "We define an empty list so that the agent will not",
249+
" error about undefined variable when ",
250+
" def.bundlesequence_classification is not defined." );
251+
"bundlesequence_classification" -> { "CFE-4855" }
252+
slist => getvalues( mergedata( "def.control_common_bundlesequence_classification" ) ),
253+
comment => concat( "We define bundlesequence_classification from Augments if it's",
254+
" available. This allows for customization without",
255+
" modifying the vendored policy." );
238256

239257
"control_common_ignore_missing_bundles" -> { "CFE-2773" }
240258
string => ifelse( strcmp( $(control_common_ignore_missing_bundles), "true" ),

0 commit comments

Comments
 (0)