Skip to content

Standardizing Link and Button appearance / type property name #522

Description

@flacoman91

I noticed the Link and Button are set up differently in what causes it to be the red button or link.

In Link, the type property does it, and in the Button component, the appearance property does it.

  • Button - appearance - primary | secondary | warning
  • Link - type - default | destructive

Is it okay to standardize it so there's less confusion and stuff to keep track of?

I would prefer appearance over type since type is a reserved keyword in Typescript

I think we should go with
appearance - default | secondary | warning

Your thoughts?
@virginiacc @anselmbradford @billhimmelsbach @natalia-fitzgerald

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions