fix tests

kgudel · kgudel · commit 8d9d09c78437 · 2026-07-30T14:46:28.000-04:00
diff --git a/common/src/test/scala/hmda/parser/filing/ParserFlowSpec.scala b/common/src/test/scala/hmda/parser/filing/ParserFlowSpec.scala
@@ -62,7 +62,7 @@ class ParserFlowSpec extends WordSpec with MustMatchers {
         .map(ByteString(_))
         .via(parseTsFlow)
         .map(_._1)
-        .map(_.swap.getOrElse)
+        .map(_.left.get)
         .runWith(TestSink.probe[List[ParserValidationError]])
         .request(1)
         .expectNext(List(IncorrectNumberOfFieldsTs("18")))
@@ -84,7 +84,7 @@ class ParserFlowSpec extends WordSpec with MustMatchers {
         .map(ByteString(_))
         .via(parseLarFlow)
         .map(_._1)
-        .map(_.swap.getOrElse)
+        .map(_.left.get)
         .runWith(TestSink.probe[List[ParserValidationError]])
         .request(badLarList.size)
         .expectNextN(
diff --git a/hmda/src/test/scala/hmda/validation/engine/2018/LarEngine2018Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2018/LarEngine2018Spec.scala
@@ -126,7 +126,7 @@ class LarEngine2018Spec extends WordSpec with ScalaCheckPropertyChecks with Must
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2018/TsEngine2018Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2018/TsEngine2018Spec.scala
@@ -39,7 +39,7 @@ class TsEngine2018Spec extends PropSpec with ScalaCheckPropertyChecks with MustM
         val validation =
           checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe
           List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))
       }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2019/LarEngine2019Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2019/LarEngine2019Spec.scala
@@ -126,7 +126,7 @@ class LarEngine2019Spec extends WordSpec with ScalaCheckPropertyChecks with Must
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2019/TSEngine2019Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2019/TSEngine2019Spec.scala
@@ -39,7 +39,7 @@ class TsEngine2019Spec extends PropSpec with ScalaCheckPropertyChecks with MustM
         val validation =
           checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe
           List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))
       }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2020/LarEngine2020QSpec.scala b/hmda/src/test/scala/hmda/validation/engine/2020/LarEngine2020QSpec.scala
@@ -130,7 +130,7 @@ class LarEngine2020QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2020/LarEngine2020Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2020/LarEngine2020Spec.scala
@@ -130,7 +130,7 @@ class LarEngine2020Spec extends WordSpec with ScalaCheckPropertyChecks with Must
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2020/TSEngine2020SQpec.scala b/hmda/src/test/scala/hmda/validation/engine/2020/TSEngine2020SQpec.scala
@@ -42,7 +42,7 @@ class TsEngine2020SQpec extends PropSpec with ScalaCheckPropertyChecks with Must
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe List(
           SyntacticalValidationError(ts.LEI, "S300", TsValidationError),
           ValidityValidationError(ts.LEI, "V718", TsValidationError)
diff --git a/hmda/src/test/scala/hmda/validation/engine/2020/TSEngine2020Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2020/TSEngine2020Spec.scala
@@ -38,7 +38,7 @@ class TsEngine2020Spec extends PropSpec with ScalaCheckPropertyChecks with MustM
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe
           List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))
 
diff --git a/hmda/src/test/scala/hmda/validation/engine/2021/LarEngine2021QSpec.scala b/hmda/src/test/scala/hmda/validation/engine/2021/LarEngine2021QSpec.scala
@@ -130,7 +130,7 @@ class LarEngine2021QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2021/LarEngine2021Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2021/LarEngine2021Spec.scala
@@ -130,7 +130,7 @@ class LarEngine2021Spec extends WordSpec with ScalaCheckPropertyChecks with Must
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2021/TsEngine2021QSpec.scala b/hmda/src/test/scala/hmda/validation/engine/2021/TsEngine2021QSpec.scala
@@ -42,7 +42,7 @@ class TsEngine2021QSpec extends PropSpec with ScalaCheckPropertyChecks with Must
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe List(
           SyntacticalValidationError(ts.LEI, "S300", TsValidationError),
           ValidityValidationError(ts.LEI, "V718", TsValidationError)
diff --git a/hmda/src/test/scala/hmda/validation/engine/2021/TsEngine2021Spec.scala b/hmda/src/test/scala/hmda/validation/engine/2021/TsEngine2021Spec.scala
@@ -38,7 +38,7 @@ class TsEngine2021Spec extends PropSpec with ScalaCheckPropertyChecks with MustM
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2022/LarEngine2022QSpec.scala b/hmda/src/test/scala/hmda/validation/engine/2022/LarEngine2022QSpec.scala
@@ -130,7 +130,7 @@ class LarEngine2022QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2022/TsEngine2022SQpec.scala b/hmda/src/test/scala/hmda/validation/engine/2022/TsEngine2022SQpec.scala
@@ -41,7 +41,7 @@ class TsEngine2022SQpec extends PropSpec with ScalaCheckPropertyChecks with Must
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe List(
           SyntacticalValidationError(ts.LEI, "S300", TsValidationError),
           ValidityValidationError(ts.LEI, "V718", TsValidationError)
diff --git a/hmda/src/test/scala/hmda/validation/engine/2023/LarEngine2023QSpec.scala b/hmda/src/test/scala/hmda/validation/engine/2023/LarEngine2023QSpec.scala
@@ -130,7 +130,7 @@ class LarEngine2023QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus
         val validation =
           checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)
         val errors =
-          validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+          validation.leftMap(errors => errors.toList).toEither.left.get
         errors must not be empty
       }
     }
diff --git a/hmda/src/test/scala/hmda/validation/engine/2023/TsEngine2023SQpec.scala b/hmda/src/test/scala/hmda/validation/engine/2023/TsEngine2023SQpec.scala
@@ -42,7 +42,7 @@ class TsEngine2023SQpec extends PropSpec with ScalaCheckPropertyChecks with Must
       ) {
         val testContext = ValidationContext(None, Some(Period(ts.year, None)))
         val validation  = checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)
-        val errors      = validation.leftMap(errors => errors.toList).toEither.swap.getOrElse
+        val errors      = validation.leftMap(errors => errors.toList).toEither.left.get
         errors mustBe List(
           SyntacticalValidationError(ts.LEI, "S300", TsValidationError),
           ValidityValidationError(ts.LEI, "V718", TsValidationError)

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ class LarEngine2018Spec extends WordSpec with ScalaCheckPropertyChecks with Must`
`126`	`126`	`val validation =`
`127`	`127`	`checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)`
`128`	`128`	`val errors =`
`129`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`129`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`130`	`130`	`errors must not be empty`
`131`	`131`	`}`
`132`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class TsEngine2018Spec extends PropSpec with ScalaCheckPropertyChecks with MustM`
`39`	`39`	`val validation =`
`40`	`40`	`checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)`
`41`	`41`	`val errors =`
`42`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`42`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`43`	`43`	`errors mustBe`
`44`	`44`	`List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ class LarEngine2019Spec extends WordSpec with ScalaCheckPropertyChecks with Must`
`126`	`126`	`val validation =`
`127`	`127`	`checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)`
`128`	`128`	`val errors =`
`129`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`129`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`130`	`130`	`errors must not be empty`
`131`	`131`	`}`
`132`	`132`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class TsEngine2019Spec extends PropSpec with ScalaCheckPropertyChecks with MustM`
`39`	`39`	`val validation =`
`40`	`40`	`checkAll(ts.copy(id = 2, quarter = 2), ts.LEI, testContext, TsValidationError)`
`41`	`41`	`val errors =`
`42`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`42`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`43`	`43`	`errors mustBe`
`44`	`44`	`List(SyntacticalValidationError(ts.LEI, "S300", TsValidationError), ValidityValidationError(ts.LEI, "V602", TsValidationError))`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ class LarEngine2020QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus`
`130`	`130`	`val validation =`
`131`	`131`	`checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)`
`132`	`132`	`val errors =`
`133`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`133`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`134`	`134`	`errors must not be empty`
`135`	`135`	`}`
`136`	`136`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ class LarEngine2021QSpec extends WordSpec with ScalaCheckPropertyChecks with Mus`
`130`	`130`	`val validation =`
`131`	`131`	`checkAll(lar, lar.larIdentifier.LEI, testContext, TsValidationError)`
`132`	`132`	`val errors =`
`133`		`- validation.leftMap(errors => errors.toList).toEither.swap.getOrElse`
	`133`	`+ validation.leftMap(errors => errors.toList).toEither.left.get`
`134`	`134`	`errors must not be empty`
`135`	`135`	`}`
`136`	`136`	`}`