Merge pull request microsoft#1978 from tyrielv/tyrielv/fix-handle-leak-getfinalpathname

tyrielv · web-flow · commit c585068ad0d5 · 2026-05-26T09:16:34.000-07:00
Fix handle leak in GetFinalPathName
diff --git a/GVFS/GVFS.NativeHooks.Common/common.windows.cpp b/GVFS/GVFS.NativeHooks.Common/common.windows.cpp
@@ -28,6 +28,7 @@ PATH_STRING GetFinalPathName(const PATH_STRING& path)
 
     wchar_t finalPathByHandle[MAX_PATH] = { 0 };
     DWORD finalPathSize = GetFinalPathNameByHandleW(fileHandle, finalPathByHandle, MAX_PATH, FILE_NAME_NORMALIZED);
+    CloseHandle(fileHandle);
     if (finalPathSize == 0)
     {
         die(ReturnCode::PathNameError, "Could not get final path name by handle for %ls, Error: %d\n", path.c_str(), GetLastError());

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ PATH_STRING GetFinalPathName(const PATH_STRING& path)`
`28`	`28`
`29`	`29`	`wchar_t finalPathByHandle[MAX_PATH] = { 0 };`
`30`	`30`	`DWORD finalPathSize = GetFinalPathNameByHandleW(fileHandle, finalPathByHandle, MAX_PATH, FILE_NAME_NORMALIZED);`
	`31`	`+ CloseHandle(fileHandle);`
`31`	`32`	`if (finalPathSize == 0)`
`32`	`33`	`{`
`33`	`34`	`die(ReturnCode::PathNameError, "Could not get final path name by handle for %ls, Error: %d\n", path.c_str(), GetLastError());`