Skip to content

Commit 9cb38a4

Browse files
committed
fix: add superagent types as prod dependency
We expose superagent's types in our own types, so this should be a production dependency. Otherwise, we will cause errors in the typescript builds of consumers (unless they skip lib check). It does mean we add an unnecessary dependency for non-ts people, but there's not any simple way around that.
1 parent 08daa24 commit 9cb38a4

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

package-lock.json

+4-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,12 @@
5757
"is-ip": "^5.0.1",
5858
"methods": "^1.1.2",
5959
"qs": "^6.12.1",
60+
"@types/superagent": "^8.1.7",
6061
"superagent": "^9"
6162
},
6263
"devDependencies": {
6364
"@eslint/js": "^9.3.0",
6465
"@types/chai": "^4.3.16",
65-
"@types/superagent": "^8.1.7",
6666
"chai": "^5.1.0",
6767
"coveralls": "^3.1.1",
6868
"eslint": "^9.3.0",

0 commit comments

Comments
 (0)