add tests for finding files and use variable for default filetypes

Author: hooksie1

digestabotctl/cmd/flags.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/chainguard-dev/platform-examples/digestabotctl/digestabot"
 	"github.com/chainguard-dev/platform-examples/digestabotctl/platforms"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -35,7 +36,7 @@ func bindFileFlags(cmd *cobra.Command) {
 
 // fileFlags adds the file flags to the passed in command
 func fileFlags(cmd *cobra.Command) {
-	cmd.PersistentFlags().StringSliceP("file-types", "f", []string{`*.yaml`, `*.yml`, `*.sh`, `*.tf`, `*.tfvars`, `Dockerfile*`, `Makefile*`}, "Files to update")
+	cmd.PersistentFlags().StringSliceP("file-types", "f", digestabot.DefaultFileTypes, "Files to update")
 	cmd.PersistentFlags().StringP("directory", "d", ".", "Directory to update files")
 }
 

digestabotctl/digestabot/digestabot.go

@@ -14,6 +14,7 @@ import (
 
 var regex = regexp.MustCompile(`[a-z0-9]+([._-][a-z0-9]+)*(/[a-z0-9]+([._-][a-z0-9]+)*)*@sha256:[a-z0-9]+`)
 var shaRegex = regexp.MustCompile(`sha256:[a-z0-9]+`)
+var DefaultFileTypes = []string{`*.yaml`, `*.yml`, `*.sh`, `*.tf`, `*.tfvars`, `Dockerfile*`, `Makefile*`}
 
 type Image struct {
 	Name        string

digestabotctl/digestabot/digestabot_test.go

@@ -6,6 +6,7 @@ import (
 	"io"
 	"log/slog"
 	"os"
+	"slices"
 	"strings"
 	"testing"
 )
@@ -63,3 +64,28 @@ func TestUpdateHashes(t *testing.T) {
 		})
 	}
 }
+
+func TestFindFiles(t *testing.T) {
+	tt := []struct {
+		name      string
+		directory string
+		fileTypes []string
+		expected  []string
+	}{
+		{name: "dockerfiles", directory: "../examples", fileTypes: []string{"Dockerfile*"}, expected: []string{"../examples/Dockerfile", "../examples/Dockerfile2", "../examples/nested_dir/Dockerfile"}},
+		{name: "all", directory: "../examples", fileTypes: DefaultFileTypes, expected: []string{"../examples/Dockerfile", "../examples/Dockerfile2", "../examples/Makefile", "../examples/nested_dir/Dockerfile", "../examples/test.yaml"}},
+	}
+
+	for _, v := range tt {
+		t.Run(v.name, func(t *testing.T) {
+			files, err := FindFiles(v.fileTypes, v.directory)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			if !slices.Equal(v.expected, files) {
+				t.Errorf("expected \n%v \n but got \n%v", v.expected, files)
+			}
+		})
+	}
+}

digestabotctl/examples/nested_dir/Dockerfile

@@ -0,0 +1,2 @@
+FROM cgr.dev/chainguard/busybox:latest@sha256:257157f6c6aa88dd934dcf6c2f140e42c2653207302788c0ed3bebb91c5311e1 as build
+

digestabotctl/examples/test.yaml

@@ -0,0 +1 @@
+image: cgr.dev/chainguard/busybox:latest@sha256:257157f6c6aa88dd934dcf6c2f140e42c2653207302788c0ed3bebb91c5311e1