Skip to content

Commit 8f00e84

Browse files
authored
fix: propagate Range field of subpackages (#1939)
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
1 parent ef04876 commit 8f00e84

File tree

4 files changed

+32
-14
lines changed

4 files changed

+32
-14
lines changed

pkg/build/build_test.go

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,26 @@ func TestConfiguration_Load(t *testing.T) {
5959
},
6060
},
6161
Subpackages: []config.Subpackage{{
62-
Name: "cats",
62+
Name: "cats",
63+
Range: "animals",
6364
Pipeline: []config.Pipeline{{
6465
Runs: "cats are angry",
6566
}},
6667
}, {
67-
Name: "dogs",
68+
Name: "dogs",
69+
Range: "animals",
6870
Pipeline: []config.Pipeline{{
6971
Runs: "dogs are loyal",
7072
}},
7173
}, {
72-
Name: "turtles",
74+
Name: "turtles",
75+
Range: "animals",
7376
Pipeline: []config.Pipeline{{
7477
Runs: "turtles are slow",
7578
}},
7679
}, {
77-
Name: "donatello",
80+
Name: "donatello",
81+
Range: "ninja-turtles",
7882
Pipeline: []config.Pipeline{
7983
{
8084
Runs: "donatello's color is purple",
@@ -85,7 +89,8 @@ func TestConfiguration_Load(t *testing.T) {
8589
},
8690
},
8791
}, {
88-
Name: "leonardo",
92+
Name: "leonardo",
93+
Range: "ninja-turtles",
8994
Pipeline: []config.Pipeline{
9095
{
9196
Runs: "leonardo's color is blue",
@@ -96,7 +101,8 @@ func TestConfiguration_Load(t *testing.T) {
96101
},
97102
},
98103
}, {
99-
Name: "michelangelo",
104+
Name: "michelangelo",
105+
Range: "ninja-turtles",
100106
Pipeline: []config.Pipeline{
101107
{
102108
Runs: "michelangelo's color is orange",
@@ -107,7 +113,8 @@ func TestConfiguration_Load(t *testing.T) {
107113
},
108114
},
109115
}, {
110-
Name: "raphael",
116+
Name: "raphael",
117+
Range: "ninja-turtles",
111118
Pipeline: []config.Pipeline{
112119
{
113120
Runs: "raphael's color is red",

pkg/build/test_test.go

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -178,31 +178,35 @@ func TestConfigurationLoad(t *testing.T) {
178178
},
179179
},
180180
Subpackages: []config.Subpackage{{
181-
Name: "cats",
181+
Name: "cats",
182+
Range: "animals",
182183
Test: &config.Test{
183184
Environment: defaultEnv(),
184185
Pipeline: []config.Pipeline{{
185186
Runs: "cats are angry",
186187
}},
187188
},
188189
}, {
189-
Name: "dogs",
190+
Name: "dogs",
191+
Range: "animals",
190192
Test: &config.Test{
191193
Environment: defaultEnv(),
192194
Pipeline: []config.Pipeline{{
193195
Runs: "dogs are loyal",
194196
}},
195197
},
196198
}, {
197-
Name: "turtles",
199+
Name: "turtles",
200+
Range: "animals",
198201
Test: &config.Test{
199202
Environment: defaultEnv(),
200203
Pipeline: []config.Pipeline{{
201204
Runs: "turtles are slow",
202205
}},
203206
},
204207
}, {
205-
Name: "donatello",
208+
Name: "donatello",
209+
Range: "ninja-turtles",
206210
Test: &config.Test{
207211
Environment: defaultEnv(),
208212
Pipeline: []config.Pipeline{
@@ -216,7 +220,8 @@ func TestConfigurationLoad(t *testing.T) {
216220
},
217221
},
218222
}, {
219-
Name: "leonardo",
223+
Name: "leonardo",
224+
Range: "ninja-turtles",
220225
Test: &config.Test{
221226
Environment: defaultEnv(),
222227
Pipeline: []config.Pipeline{
@@ -229,7 +234,8 @@ func TestConfigurationLoad(t *testing.T) {
229234
},
230235
}},
231236
}, {
232-
Name: "michelangelo",
237+
Name: "michelangelo",
238+
Range: "ninja-turtles",
233239
Test: &config.Test{
234240
Environment: defaultEnv(),
235241
Pipeline: []config.Pipeline{
@@ -242,7 +248,8 @@ func TestConfigurationLoad(t *testing.T) {
242248
},
243249
}},
244250
}, {
245-
Name: "raphael",
251+
Name: "raphael",
252+
Range: "ninja-turtles",
246253
Test: &config.Test{
247254
Environment: defaultEnv(),
248255
Pipeline: []config.Pipeline{

pkg/config/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1293,6 +1293,7 @@ func replaceSubpackage(r *strings.Replacer, detectedCommit string, in Subpackage
12931293
Commit: replaceCommit(detectedCommit, in.Commit),
12941294
Checks: in.Checks,
12951295
Test: replaceTest(r, in.Test),
1296+
Range: in.Range,
12961297
}
12971298
}
12981299

pkg/config/config_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,7 @@ subpackages:
221221
require.Equal(t, cfg.Subpackages[0].Dependencies.Runtime[0], "wow-some-kinda-dynamically-linked-library-i-guess=1.0")
222222
require.True(t, cfg.Subpackages[0].Options.NoProvides)
223223
require.Equal(t, cfg.Subpackages[0].Test.Environment.Contents.Packages[1], "A-default-jvm")
224+
require.Equal(t, cfg.Subpackages[0].Range, "I-am-a-range")
224225
}
225226

226227
func Test_rangeSubstitutionsPriorities(t *testing.T) {
@@ -276,6 +277,8 @@ subpackages:
276277
require.Equal(t, cfg.Subpackages[1].Pipeline[0].Needs.Packages[0], "b")
277278
require.Equal(t, cfg.Subpackages[0].Pipeline[0].Pipeline[0].Runs, "exit 1")
278279
require.Equal(t, cfg.Subpackages[1].Pipeline[0].Pipeline[0].Runs, "exit 1")
280+
require.Equal(t, cfg.Subpackages[0].Range, "I-am-a-range")
281+
require.Equal(t, cfg.Subpackages[1].Range, "I-am-a-range")
279282
}
280283

281284
func Test_propagatePipelines(t *testing.T) {

0 commit comments

Comments
 (0)