fix: exclude fifos in WorkspaceTar (#1973)

89luca89 · web-flow · commit a9f69e67ee77 · 2025-05-08T09:35:05.000+02:00
* fix: exclude fifos in WorkspaceTar

Signed-off-by: Luca Di Maio &lt;luca.dimaio1@gmail.com&gt;

* tests: add dpkg to test regressions on QEMU

Signed-off-by: Luca Di Maio &lt;luca.dimaio1@gmail.com&gt;

---------

Signed-off-by: Luca Di Maio &lt;luca.dimaio1@gmail.com&gt;
diff --git a/.github/workflows/wolfi-presubmit.yaml b/.github/workflows/wolfi-presubmit.yaml
@@ -62,6 +62,7 @@ jobs:
           - tini
           - lzo
           - bubblewrap
+          - dpkg
           #- gdk-pixbuf # Looks like this is broken again, see: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/515
           - gitsign
           - guac
diff --git a/pkg/container/qemu_runner.go b/pkg/container/qemu_runner.go
@@ -402,7 +402,7 @@ func (bw *qemu) WorkspaceTar(ctx context.Context, cfg *Config) (io.ReadCloser, e
 		nil,
 		outFile,
 		false,
-		[]string{"sh", "-c", "cd /home/build && tar cvpzf - --xattrs --acls *"},
+		[]string{"sh", "-c", "cd /home/build && tar cvpzf - --xattrs --acls --exclude='*fifo*' *"},
 	)
 	if err != nil {
 		return nil, err

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ func (bw qemu) WorkspaceTar(ctx context.Context, cfg Config) (io.ReadCloser, e`
`402`	`402`	`nil,`
`403`	`403`	`outFile,`
`404`	`404`	`false,`
`405`		`- []string{"sh", "-c", "cd /home/build && tar cvpzf - --xattrs --acls *"},`
	`405`	`+ []string{"sh", "-c", "cd /home/build && tar cvpzf - --xattrs --acls --exclude='fifo' *"},`
`406`	`406`	`)`
`407`	`407`	`if err != nil {`
`408`	`408`	`return nil, err`