perf(protovalidate): cache validator instead of constructing per call (#3156)

Author: matiasinsaurralde

app/controlplane/pkg/biz/casclient.go

@@ -167,12 +167,7 @@ func (uc *CASClientUseCase) IsReady(ctx context.Context) (bool, error) {
 		return false, errors.New("missing CAS server configuration")
 	}
 
-	v, err := protovalidate.New()
-	if err != nil {
-		return false, fmt.Errorf("failed to create validator: %w", err)
-	}
-
-	if err := v.Validate(uc.casServerConf); err != nil {
+	if err := protovalidate.Validate(uc.casServerConf); err != nil {
 		return false, fmt.Errorf("invalid CAS client configuration: %w", err)
 	}
 

app/controlplane/pkg/unmarshal/unmarshal.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2024-2025 The Chainloop Authors.
+// Copyright 2024-2026 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -56,17 +56,11 @@ func (v *validatorAdapter) Validate(msg proto.Message) error {
 	return v.validator.Validate(msg)
 }
 
-func FromRaw(body []byte, format RawFormat, out proto.Message, doValidate bool) error {
-	var validator protovalidate.Validator
-	var err error
-
-	if doValidate {
-		validator, err = protovalidate.New()
-		if err != nil {
-			return fmt.Errorf("could not create validator: %w", err)
-		}
-	}
+// yamlValidator wraps the protovalidate global Validator for use with protoyaml,
+// initialised once and reused across calls.
+var yamlValidator = &validatorAdapter{validator: protovalidate.GlobalValidator}
 
+func FromRaw(body []byte, format RawFormat, out proto.Message, doValidate bool) error {
 	switch format {
 	case RawFormatJSON:
 		if err := protojson.Unmarshal(body, out); err != nil {
@@ -76,7 +70,7 @@ func FromRaw(body []byte, format RawFormat, out proto.Message, doValidate bool)
 		// protoyaml allows validating the contract while unmarshalling
 		yamlOpts := protoyaml.UnmarshalOptions{}
 		if doValidate {
-			yamlOpts.Validator = &validatorAdapter{validator: validator}
+			yamlOpts.Validator = yamlValidator
 		}
 
 		if err := yamlOpts.Unmarshal(body, out); err != nil {
@@ -97,9 +91,8 @@ func FromRaw(body []byte, format RawFormat, out proto.Message, doValidate bool)
 		return fmt.Errorf("unsupported format: %s", format)
 	}
 
-	if validator != nil {
-		err = validator.Validate(out)
-		if err != nil {
+	if doValidate {
+		if err := protovalidate.Validate(out); err != nil {
 			return fmt.Errorf("error validating raw message: %w", err)
 		}
 	}

pkg/attestation/crafter/api/attestation/v1/crafting_state_validations.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2024-2025 The Chainloop Authors.
+// Copyright 2024-2026 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -27,15 +27,10 @@ import (
 // ValidateComplete makes sure that the crafting state has been completed
 // before it gets passed to the renderer
 func (state *CraftingState) ValidateComplete(dryRun bool) error {
-	validator, err := protovalidate.New()
-	if err != nil {
-		return fmt.Errorf("could not create validator: %w", err)
-	}
-
 	// We do not want to validate the schema of the state if we are just doing a dry run
 	// since it's known to not to contain the workflow metadata information
 	if !dryRun {
-		if err := validator.Validate(state); err != nil {
+		if err := protovalidate.Validate(state); err != nil {
 			return fmt.Errorf("invalid crafting state: %w", err)
 		}
 	}

pkg/attestation/crafter/crafter.go

@@ -67,7 +67,6 @@ type Crafter struct {
 	stateManager  StateManager
 	// Authn is used to authenticate with the OCI registry
 	ociRegistryAuth authn.Keychain
-	validator       protovalidate.Validator
 
 	// attestation client is used to load chainloop policies
 	attClient v1.AttestationServiceClient
@@ -166,19 +165,13 @@ func (c *Crafter) RunCollectors(ctx context.Context, attestationID string, casBa
 func NewCrafter(stateManager StateManager, attClient v1.AttestationServiceClient, opts ...NewOpt) (*Crafter, error) {
 	noopLogger := zerolog.Nop()
 
-	validator, err := protovalidate.New()
-	if err != nil {
-		return nil, fmt.Errorf("creating proto validator: %w", err)
-	}
-
 	cw, _ := os.Getwd()
 	c := &Crafter{
 		Logger:       &noopLogger,
 		workingDir:   cw,
 		stateManager: stateManager,
 		// By default we authenticate with the current user's keychain (i.e ~/.docker/config.json)
 		ociRegistryAuth: authn.DefaultKeychain,
-		validator:       validator,
 		attClient:       attClient,
 	}
 
@@ -684,7 +677,7 @@ func (c *Crafter) addMaterial(ctx context.Context, m *schemaapi.CraftingSchema_M
 		}
 	}
 
-	if err := c.validator.Validate(mt); err != nil {
+	if err := protovalidate.Validate(mt); err != nil {
 		return nil, fmt.Errorf("validation error: %w", err)
 	}
 

pkg/attestation/crafter/materials/materials.go

@@ -224,12 +224,7 @@ func Craft(ctx context.Context, materialSchema *schemaapi.CraftingSchema_Materia
 	var crafter Craftable
 	var err error
 
-	validator, err := protovalidate.New()
-	if err != nil {
-		return nil, fmt.Errorf("could not create validator: %w", err)
-	}
-
-	if err := validator.Validate(materialSchema); err != nil {
+	if err := protovalidate.Validate(materialSchema); err != nil {
 		return nil, fmt.Errorf("validating material: %w", err)
 	}
 

pkg/credentials/manager/manager.go

@@ -1,5 +1,5 @@
 //
-// Copyright 2023 The Chainloop Authors.
+// Copyright 2023-2026 The Chainloop Authors.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -56,12 +56,7 @@ func NewFromConfig(conf *api.Credentials, role credentials.Role, l log.Logger) (
 }
 
 func validateConfig(msg protoreflect.ProtoMessage) error {
-	validator, err := protovalidate.New()
-	if err != nil {
-		return fmt.Errorf("creating validator: %w", err)
-	}
-
-	return validator.Validate(msg)
+	return protovalidate.Validate(msg)
 }
 
 func newAzureKBManager(conf *api.Credentials_AzureKeyVault, prefix string, r credentials.Role, l log.Logger) (*azurekv.Manager, error) {

pkg/policies/policies.go

@@ -705,15 +705,9 @@ func (pv *PolicyVerifier) getLoader(attachment *v1.PolicyAttachment) (Loader, er
 }
 
 func validateResource(m proto.Message) error {
-	validator, err := protovalidate.New()
-	if err != nil {
+	if err := protovalidate.Validate(m); err != nil {
 		return fmt.Errorf("validating policy spec: %w", err)
 	}
-	err = validator.Validate(m)
-	if err != nil {
-		return fmt.Errorf("validating policy spec: %w", err)
-	}
-
 	return nil
 }