You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, my question is, is it a mistake that RadioGroupContextProps is not exported from radio-group.ts files for React and Solid?
I'm creating Svelte version of Ark and I stepped into this and I was wondering weather this was a typo or something to do with JSX.
I took a look into other (Ark) React components and they were exporting both things from both files. So, it looks like this wasn't intentional and it's a typo. Should I create an issue?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Inside this file:
packages\react\src\components\radio-group\radio-group-context.tsx
these are created:export interface RadioGroupContextProps {
export const RadioGroupContext = (props: RadioGroupContextProps) =>
Inside this file:
packages\react\src\components\radio-group\radio-group.ts
this is the export code:Only
RadioGroupContext
is export, once as a component and once as a type.Inside this file
packages\react\src\components\radio-group\index.ts
this is the export code for the same component:Both are exported.
Inside the export files for the same component for Vue, both type end component are exported in both of the export files:
packages\vue\src\components\radio-group\index.ts
packages\vue\src\components\radio-group\radio-group.ts
So, my question is, is it a mistake that
RadioGroupContextProps
is not exported fromradio-group.ts
files for React and Solid?I'm creating Svelte version of Ark and I stepped into this and I was wondering weather this was a typo or something to do with JSX.
I took a look into other (Ark) React components and they were exporting both things from both files. So, it looks like this wasn't intentional and it's a typo. Should I create an issue?
Beta Was this translation helpful? Give feedback.
All reactions