Skip to content

Commit 9453c9b

Browse files
committed
fix(core): expand breakpoint at rule consistently
1 parent fd7e11f commit 9453c9b

File tree

4 files changed

+36
-2
lines changed

4 files changed

+36
-2
lines changed

.changeset/sharp-goats-draw.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@pandacss/core': patch
3+
---
4+
5+
Fix issue where `@breakpoint` from `hideBelow` or `hideFrom` might not be compiled to media query correctly

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"git add --all packages/studio/"
7171
]
7272
},
73-
"packageManager": "pnpm@10.9.0",
73+
"packageManager": "pnpm@10.10.0",
7474
"pnpm": {
7575
"overrides": {
7676
"@swc/helpers@~0.4": "0.4.36"

packages/core/__tests__/atomic-rule.test.ts

+26
Original file line numberDiff line numberDiff line change
@@ -670,4 +670,30 @@ describe('atomic / with direct nesting', () => {
670670
}"
671671
`)
672672
})
673+
674+
test('responsive helpers', () => {
675+
expect(
676+
css({
677+
hideFrom: 'sm',
678+
}),
679+
).toMatchInlineSnapshot(`
680+
"@layer utilities {
681+
@media screen and (min-width: 40rem) {
682+
.hide_sm {
683+
display: none;
684+
}
685+
}
686+
}"
687+
`)
688+
689+
expect(css({ hideBelow: 'lg' })).toMatchInlineSnapshot(`
690+
"@layer utilities {
691+
@media screen and (max-width: 63.9975rem) {
692+
.show_lg {
693+
display: none;
694+
}
695+
}
696+
}"
697+
`)
698+
})
673699
})

packages/core/src/stylesheet.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,13 @@ export class Stylesheet {
9595
}
9696

9797
getLayerCss = (...layers: CascadeLayer[]) => {
98+
const breakpoints = this.context.conditions.breakpoints
9899
return optimizeCss(
99100
layers
100101
.map((layer: CascadeLayer) => {
101-
return this.context.layers.getLayerRoot(layer).toString()
102+
const root = this.context.layers.getLayerRoot(layer)
103+
breakpoints.expandScreenAtRule(root as postcss.Root)
104+
return root.toString()
102105
})
103106
.join('\n'),
104107
{

0 commit comments

Comments
 (0)