Skip to content

Commit 37801b4

Browse files
committed
Update test_data_collected_from_virt_launcher[test_domcapabilities] for s390x
1. As ovmfpath is empty for s390x, changed to machine_type field instead 2. As architectureConfiguration for s390x is fixed in kubevirt 1.7, temporarily added the defaults in the test Signed-off-by: chandramerla <Chandra.Merla@ibm.com>
1 parent 458ea52 commit 37801b4

1 file changed

Lines changed: 20 additions & 10 deletions

File tree

tests/install_upgrade_operators/must_gather/test_must_gather_vms.py

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
validate_no_empty_files_collected_must_gather_vm,
3232
)
3333
from tests.os_params import FEDORA_LATEST
34-
from utilities.constants import ARM_64, COUNT_FIVE
34+
from utilities.constants import ARM_64, COUNT_FIVE, S390X
35+
from utilities.infra import is_jira_open
3536

3637
pytestmark = [pytest.mark.post_upgrade, pytest.mark.skip_must_gather_collection, pytest.mark.arm64, pytest.mark.s390x]
3738

@@ -43,15 +44,24 @@ def kubevirt_architecture_configuration_scope_session(
4344
kubevirt_resource_scope_session,
4445
nodes_cpu_architecture,
4546
):
46-
kubevirt_architecture_config = kubevirt_resource_scope_session.instance.to_dict()["spec"]["configuration"][
47-
"architectureConfiguration"
48-
][nodes_cpu_architecture]
47+
kubevirt_architecture_config = {}
4948

50-
# Default value of kubevirt.spec.configuration.architectureConfiguration.arm64.ovmfPath is
51-
# '/usr/share/AAVMF' but the files in this location are symlinked to
52-
# '/usr/share/edk2/aarch64'. VM domain capabilities refer to symlinked file.
53-
if nodes_cpu_architecture == ARM_64:
54-
kubevirt_architecture_config["ovmfPath"] = "/usr/share/edk2/aarch64"
49+
# TODO: This block for s390x to be removed once we move to kubevirt version 1.7 as this is
50+
# fixed in https://github.com/kubevirt/kubevirt/issues/14953
51+
if nodes_cpu_architecture == S390X and is_jira_open(jira_id="CNV-70161"):
52+
kubevirt_architecture_config["ovmfPath"] = ""
53+
kubevirt_architecture_config["machineType"] = "s390-ccw-virtio"
54+
kubevirt_architecture_config["emulatedMachines"] = "s390-ccw-virtio*"
55+
else:
56+
kubevirt_architecture_config = kubevirt_resource_scope_session.instance.to_dict()["spec"]["configuration"][
57+
"architectureConfiguration"
58+
][nodes_cpu_architecture]
59+
60+
# Default value of kubevirt.spec.configuration.architectureConfiguration.arm64.ovmfPath is
61+
# '/usr/share/AAVMF' but the files in this location are symlinked to
62+
# '/usr/share/edk2/aarch64'. VM domain capabilities refer to symlinked file.
63+
if nodes_cpu_architecture == ARM_64:
64+
kubevirt_architecture_config["ovmfPath"] = "/usr/share/edk2/aarch64"
5565
return kubevirt_architecture_config
5666

5767

@@ -170,7 +180,7 @@ class TestMustGatherVmDetails:
170180
),
171181
pytest.param(
172182
{FILE_SUFFIX: DOMCAPABILITIES_XML, SECTION_TITLE: None},
173-
"<value>{ovmfpath}",
183+
"<path>/usr/libexec/qemu-kvm</path>",
174184
marks=(pytest.mark.polarion("CNV-10519")),
175185
id="test_domcapabilities",
176186
),

0 commit comments

Comments
 (0)