Skip to content

Commit c4f5e57

Browse files
Apply Den suggestions from code review
Co-authored-by: Den Shchedrivyi <dshchedr@redhat.com>
1 parent db2ad59 commit c4f5e57

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

tests/conftest.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2773,11 +2773,8 @@ def cluster_modern_cpu_model_scope_class(
27732773

27742774

27752775
@pytest.fixture(scope="function")
2776-
def non_default_machine_type():
2777-
if is_x86_64():
2778-
return MachineTypesNames.pc_q35_rhel7_6
2779-
elif is_s390x():
2780-
return MachineTypesNames.s390_ccw_virtio
2776+
def non_default_machine_type(is_s390x_cluster):
2777+
return MachineTypesNames.s390_ccw_virtio if is_s390x_cluster else MachineTypesNames.pc_q35_rhel7_6
27812778
else:
27822779
pytest.skip("Unsupported architecture for this test")
27832780

tests/virt/node/general/test_machinetype.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,10 +112,10 @@ def test_default_machine_type(machine_type_from_kubevirt_config, vm):
112112
marks=[pytest.mark.polarion("CNV-3311")],
113113
)
114114
],
115-
indirect=["vm_with_non_default_machine_type"],
115+
indirect=True,
116116
)
117117
@pytest.mark.s390x
118-
def test_vm_machine_type(vm_with_non_default_machine_type, non_default_machine_type):
118+
def test_vm_machine_type(non_default_machine_type, vm_with_non_default_machine_type):
119119
validate_machine_type(vm=vm_with_non_default_machine_type, expected_machine_type=non_default_machine_type)
120120

121121

0 commit comments

Comments
 (0)