Skip to content

Possible optimizations for commitMode: github-api #474

@h3rmanj

Description

@h3rmanj

When doing my testing in #472, I noticed some possible oppertunities for optimization for the commitMode: github-api.

Creating tags/releases

#472 (comment)

I think we could reduce the API requests when creating releases/tags in half, if you provide target_commitish to the createRelease call, and drop the createRef call that creates the tag.

We would need to check that it still achieves the desired results in regards to signing tags.

Creating pull requests

#472 (comment)

When commitMode: github creates a pull request, it does the following:

  • It first pushes the base branch to the changeset branch <- This could be removed
  • Then commits the result from version
  • Then opens a pull request

And on subsequent changes, it also closes the pull request before opening a new one (in addition to the double push), which I suspect could be removed as well.

cc @s0

Sub-issues

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions