Align glob matching with Changesets

Author: Andarist

get-changed-packages.ts

@@ -10,7 +10,7 @@ import type {
 } from "@changesets/types";
 import type { Packages, Tool } from "@manypkg/get-packages";
 import jsYaml from "js-yaml";
-import micromatch from "micromatch";
+import picomatch from "picomatch";
 import type { ProbotOctokit } from "probot";
 import { isChangeset } from "./is-changeset.ts";
 
@@ -60,7 +60,31 @@ function matchGlobs(
 ): Array<string> {
   return paths.filter((path) => {
     const relativePath = nodePath.relative(cwd, path) || ".";
-    return micromatch.isMatch(relativePath, globs);
+    return globMatchSome([relativePath], globs);
+  });
+}
+
+// Mirrors https://github.com/changesets/changesets/blob/5eeb0125f2766b9458aa1725900430b27b24116e/packages/git/src/index.ts#L346-L374
+function globMatchSome(paths: ReadonlyArray<string>, patterns?: ReadonlyArray<string>): boolean {
+  if (!patterns) return paths.length > 0;
+
+  const matchers = patterns.map((pattern) => picomatch(pattern, undefined, true));
+  return paths.some((path) => {
+    if (path.includes("\\")) {
+      path = path.replaceAll("\\", "/");
+    }
+
+    let passed = false;
+    for (const matcher of matchers) {
+      if (!passed) {
+        if (!matcher.state.negated && matcher(path)) {
+          passed = true;
+        }
+      } else if (matcher.state.negated && !matcher(path)) {
+        passed = false;
+      }
+    }
+    return passed;
   });
 }
 
@@ -241,7 +265,7 @@ export const getChangedPackages = async ({
 
   const config = parseConfig(await rawConfigPromise, packages);
 
-  // https://github.com/changesets/changesets/blob/6c250f58a128350c6905ed16691a25bf0c8bae0c/packages/git/src/index.ts#L264-L286
+  // Mirrors https://github.com/changesets/changesets/blob/5eeb0125f2766b9458aa1725900430b27b24116e/packages/git/src/index.ts#L273-L304
   const changedPackages = packages.packages
     .toSorted((pkgA, pkgB) => pkgB.dir.length - pkgA.dir.length)
     .filter((pkg) => {
@@ -259,7 +283,7 @@ export const getChangedPackages = async ({
 
       return (
         changedPackageFiles.length > 0 &&
-        micromatch(changedPackageFiles, config.changedFilePatterns).length > 0
+        globMatchSome(changedPackageFiles, config.changedFilePatterns)
       );
     })
     .map((pkg) => pkg.packageJson.name);

package.json

@@ -28,12 +28,12 @@
     "@sentry/node": "^6.0.0",
     "@types/js-yaml": "^3.12.2",
     "@types/markdown-table": "^2.0.0",
-    "@types/micromatch": "^4.0.1",
     "@types/node": "^25.5.0",
+    "@types/picomatch": "^4.0.3",
     "human-id": "^4.1.3",
     "js-yaml": "^3.14.0",
     "markdown-table": "^2.0.0",
-    "micromatch": "^4.0.2",
+    "picomatch": "^4.0.4",
     "probot": "^12.2.4",
     "typescript": "^6.0.2"
   },

pnpm-lock.yaml

@@ -755,7 +755,7 @@ thing
     const { requests } = usePrState(server, {
       files: {
         ".changeset/config.json": JSON.stringify({
-          changedFilePatterns: ["src/**"],
+          changedFilePatterns: ["src/**", "!src/generated/**"],
         }),
         "package.json": JSON.stringify({
           name: "test",
@@ -769,6 +769,13 @@ thing
           name: "pkg-b",
         }),
         "packages/b/src/index.ts": [{ status: "added" }, "export const b = true;"],
+        "packages/c/package.json": JSON.stringify({
+          name: "pkg-c",
+        }),
+        "packages/c/src/generated/index.ts": [
+          { status: "added" },
+          "export const generated = true;",
+        ],
       },
       comments: [],
     });
@@ -783,6 +790,7 @@ thing
 
     expect(serializedRequests).toContain("%22pkg-b%22");
     expect(serializedRequests).not.toContain("%22pkg-a%22");
+    expect(serializedRequests).not.toContain("%22pkg-c%22");
   });
 
   it("attributes changed files to the deepest matching workspace package", async ({