CA-422072 Add new fields to host create params

For the new added unit test which check host create
params, need to add the new fields to create params.
This check is mainly for pool join case. Without the
params, the values will be set to default values
when the supporter host obj is created. Then the value
may be lost after pool-join.
However, for the fields in the feature, the values will
be set by dbsync. So the values can be set correctly
after restart during the pool-join. So there will not be
defects.
On the other hand, there is also no harm for adding them
to create_params. It can pass the new added unit test
and set the value correctly when host object is created
during pool-join. So add them in this commit.

Signed-off-by: Changlei Li <changlei.li@cloud.com>

Author: changlei-li

ocaml/idl/datamodel_host.ml

@@ -1209,6 +1209,17 @@ let license_remove =
        to the unlicensed edition"
     ~allowed_roles:_R_POOL_OP ()
 
+let host_ntp_mode =
+  Enum
+    ( "host_ntp_mode"
+    , [
+        ("DHCP", "Using NTP servers assigned by DHCP to sync time")
+      ; ("Custom", "Using custom NTP servers configured by user to sync time")
+      ; ("Factory", "Using built-in NTP servers to sync time")
+      ; ("Disabled", "NTP is disabled on the host")
+      ]
+    )
+
 let create_params =
   [
     {
@@ -1406,6 +1417,41 @@ let create_params =
     ; param_release= numbered_release "25.38.0-next"
     ; param_default= Some (VBool false)
     }
+  ; {
+      param_type= String
+    ; param_name= "max_cstate"
+    ; param_doc=
+        "The maximum C-state that the host is allowed to enter, \"\" means \
+         unlimited; \"N\" means limit to CN; \"N,M\" means limit to CN with \
+         max sub cstate M."
+    ; param_release= numbered_release "25.38.0-next"
+    ; param_default= Some (VString "")
+    }
+  ; {
+      param_type= host_ntp_mode
+    ; param_name= "ntp_mode"
+    ; param_doc=
+        "Indicates NTP servers are assigned by DHCP, or configured by user, or \
+         the factory servers, or NTP is disabled"
+    ; param_release= numbered_release "25.38.0-next"
+    ; param_default= Some (VEnum "Factory")
+    }
+  ; {
+      param_type= Set String
+    ; param_name= "ntp_custom_servers"
+    ; param_doc=
+        "Custom NTP servers configured by users, used in Custom NTP mode"
+    ; param_release= numbered_release "25.38.0-next"
+    ; param_default= Some (VSet [])
+    }
+  ; {
+      param_type= String
+    ; param_name= "timezone"
+    ; param_doc=
+        "The time zone identifier as defined in the IANA Time Zone Database"
+    ; param_release= numbered_release "25.38.0-next"
+    ; param_default= Some (VString "UTC")
+    }
   ]
 
 let create =
@@ -2584,17 +2630,6 @@ let set_max_cstate =
       ]
     ~allowed_roles:_R_POOL_OP ()
 
-let host_ntp_mode =
-  Enum
-    ( "host_ntp_mode"
-    , [
-        ("DHCP", "Using NTP servers assigned by DHCP to sync time")
-      ; ("Custom", "Using custom NTP servers configured by user to sync time")
-      ; ("Factory", "Using built-in NTP servers to sync time")
-      ; ("Disabled", "NTP is disabled on the host")
-      ]
-    )
-
 let set_ntp_mode =
   call ~name:"set_ntp_mode" ~lifecycle:[] ~doc:"Set the NTP mode for the host"
     ~params:

ocaml/tests/common/test_common.ml

@@ -184,7 +184,8 @@ let make_host ~__context ?(uuid = make_uuid ()) ?(name_label = "host")
       ~last_update_hash ~ssh_enabled ~ssh_enabled_timeout ~ssh_expiry
       ~console_idle_timeout ~ssh_auto_mode ~secure_boot
       ~software_version:(Xapi_globs.software_version ())
-      ~https_only
+      ~https_only ~max_cstate:"" ~ntp_mode:`Factory ~ntp_custom_servers:[]
+      ~timezone:"UTC"
   in
   Db.Host.set_cpu_info ~__context ~self:host ~value:default_cpu_info ;
   host

ocaml/tests/test_host.ml

@@ -27,7 +27,8 @@ let add_host __context name =
        ~ssh_enabled:true ~ssh_enabled_timeout:0L ~ssh_expiry:Clock.Date.epoch
        ~console_idle_timeout:0L ~ssh_auto_mode:false ~secure_boot:false
        ~software_version:(Xapi_globs.software_version ())
-       ~https_only:false
+       ~https_only:false ~max_cstate:"" ~ntp_mode:`Factory
+       ~ntp_custom_servers:[] ~timezone:"UTC"
     )
 
 (* Creates an unlicensed pool with the maximum number of hosts *)

ocaml/xapi/dbsync_slave.ml

@@ -66,7 +66,8 @@ let create_localhost ~__context info =
         ~console_idle_timeout:Constants.default_console_idle_timeout
         ~ssh_auto_mode:!Xapi_globs.ssh_auto_mode_default
         ~secure_boot:false ~software_version:[]
-        ~https_only:!Xapi_globs.https_only
+        ~https_only:!Xapi_globs.https_only ~max_cstate:"" ~ntp_mode:`Factory
+        ~ntp_custom_servers:[] ~timezone:"UTC"
     in
     ()
 

ocaml/xapi/xapi_host.ml

@@ -1029,7 +1029,8 @@ let create ~__context ~uuid ~name_label ~name_description:_ ~hostname ~address
     ~license_params ~edition ~license_server ~local_cache_sr ~chipset_info
     ~ssl_legacy:_ ~last_software_update ~last_update_hash ~ssh_enabled
     ~ssh_enabled_timeout ~ssh_expiry ~console_idle_timeout ~ssh_auto_mode
-    ~secure_boot ~software_version ~https_only =
+    ~secure_boot ~software_version ~https_only ~max_cstate ~ntp_mode
+    ~ntp_custom_servers ~timezone =
   (* fail-safe. We already test this on the joining host, but it's racy, so multiple concurrent
      pool-join might succeed. Note: we do it in this order to avoid a problem checking restrictions during
      the initial setup of the database *)
@@ -1094,8 +1095,7 @@ let create ~__context ~uuid ~name_label ~name_description:_ ~hostname ~address
     ~recommended_guidances:[] ~latest_synced_updates_applied:`unknown
     ~pending_guidances_recommended:[] ~pending_guidances_full:[] ~ssh_enabled
     ~ssh_enabled_timeout ~ssh_expiry ~console_idle_timeout ~ssh_auto_mode
-    ~max_cstate:"" ~secure_boot ~ntp_mode:`Factory ~ntp_custom_servers:[]
-    ~timezone:"UTC" ;
+    ~max_cstate ~secure_boot ~ntp_mode ~ntp_custom_servers ~timezone ;
   (* If the host we're creating is us, make sure its set to live *)
   Db.Host_metrics.set_last_updated ~__context ~self:metrics ~value:(Date.now ()) ;
   Db.Host_metrics.set_live ~__context ~self:metrics ~value:host_is_us ;

ocaml/xapi/xapi_host.mli

@@ -139,6 +139,10 @@ val create :
   -> secure_boot:bool
   -> software_version:(string * string) list
   -> https_only:bool
+  -> max_cstate:string
+  -> ntp_mode:API.host_ntp_mode
+  -> ntp_custom_servers:string list
+  -> timezone:string
   -> [`host] Ref.t
 
 val destroy : __context:Context.t -> self:API.ref_host -> unit

ocaml/xapi/xapi_pool.ml

@@ -1062,6 +1062,9 @@ let rec create_or_get_host_on_master __context rpc session_id (host_ref, host) :
           ~secure_boot:host.API.host_secure_boot
           ~software_version:host.API.host_software_version
           ~https_only:host.API.host_https_only
+          ~max_cstate:host.API.host_max_cstate ~ntp_mode:host.API.host_ntp_mode
+          ~ntp_custom_servers:host.API.host_ntp_custom_servers
+          ~timezone:host.API.host_timezone
       in
       (* Copy other-config into newly created host record: *)
       no_exn