From c4795fe77254c4843e6350a022a4032413be30f8 Mon Sep 17 00:00:00 2001 From: Ed Sungik Choi Date: Tue, 17 Dec 2024 17:09:04 +0900 Subject: [PATCH] feat(components): apply the new alpha source size style to related components --- .../components/AlphaAvatar/Avatar.module.scss | 8 -------- .../src/components/AlphaAvatar/Avatar.tsx | 5 ++++- .../src/components/AlphaAvatar/Avatar.types.ts | 13 ++----------- .../AlphaAvatarGroup/AvatarGroup.module.scss | 11 +---------- .../AlphaAvatarGroup/AvatarGroup.tsx | 12 +++++++----- .../src/components/AlphaIcon/Icon.module.scss | 18 ------------------ .../src/components/AlphaIcon/Icon.tsx | 5 +++-- .../src/components/AlphaIcon/Icon.types.ts | 8 ++++++-- 8 files changed, 23 insertions(+), 57 deletions(-) diff --git a/packages/bezier-react/src/components/AlphaAvatar/Avatar.module.scss b/packages/bezier-react/src/components/AlphaAvatar/Avatar.module.scss index 4280403bc0..ae7d3aeb5a 100644 --- a/packages/bezier-react/src/components/AlphaAvatar/Avatar.module.scss +++ b/packages/bezier-react/src/components/AlphaAvatar/Avatar.module.scss @@ -1,7 +1,5 @@ @use '../../styles/mixins/dimension'; -$avatar-sizes: 16, 20, 24, 30, 36, 42, 48, 72, 90, 120; - .Avatar { position: relative; display: block; @@ -10,12 +8,6 @@ $avatar-sizes: 16, 20, 24, 30, 36, 42, 48, 72, 90, 120; pointer-events: none; opacity: var(--alpha-opacity-disabled); } - - @each $size in $avatar-sizes { - &:where(.size-#{$size}) { - @include dimension.square(#{$size}px); - } - } } .AvatarImage { diff --git a/packages/bezier-react/src/components/AlphaAvatar/Avatar.tsx b/packages/bezier-react/src/components/AlphaAvatar/Avatar.tsx index e8cc6f6b4d..182b736395 100644 --- a/packages/bezier-react/src/components/AlphaAvatar/Avatar.tsx +++ b/packages/bezier-react/src/components/AlphaAvatar/Avatar.tsx @@ -4,6 +4,7 @@ import { forwardRef, isValidElement, useMemo } from 'react' import classNames from 'classnames' +import { getSourceSizeClassName } from '~/src/types/alpha-props-helpers' import { isEmpty } from '~/src/utils/type' import { useAvatarContext } from '~/src/components/AlphaAvatar/AvatarSizeContext' @@ -127,11 +128,13 @@ export const Avatar = forwardRef(function Avatar( ) }, [status, size, children]) + console.log(getSourceSizeClassName(size)) + return (
* + * { margin-left: var(--b-avatar-group-spacing); } @@ -49,5 +40,5 @@ position: relative; display: flex; align-items: center; - height: var(--b-avatar-group-size); + height: 100%; } diff --git a/packages/bezier-react/src/components/AlphaAvatarGroup/AvatarGroup.tsx b/packages/bezier-react/src/components/AlphaAvatarGroup/AvatarGroup.tsx index ee65fe7897..cc53dcc2ea 100644 --- a/packages/bezier-react/src/components/AlphaAvatarGroup/AvatarGroup.tsx +++ b/packages/bezier-react/src/components/AlphaAvatarGroup/AvatarGroup.tsx @@ -37,6 +37,8 @@ function getRestAvatarListCountText(count: number, max: number) { function getProperIconSize(size: AlphaAvatarSize) { return ( { + 10: 'xxs', + 12: 'xxs', 16: 'xxs', 20: 'xxs', 24: 'xs', @@ -44,6 +46,7 @@ function getProperIconSize(size: AlphaAvatarSize) { 36: 'm', 42: 'm', 48: 'l', + 60: 'l', 72: 'l', 90: 'l', 120: 'l', @@ -55,6 +58,8 @@ function getProperIconSize(size: AlphaAvatarSize) { function getProperTypoSize(size: AlphaAvatarSize) { return ( { + 10: '12', + 12: '12', 16: '12', 20: '12', 24: '13', @@ -62,6 +67,7 @@ function getProperTypoSize(size: AlphaAvatarSize) { 36: '16', 42: '18', 48: '24', + 60: '24', 72: '24', 90: '24', 120: '24', @@ -202,11 +208,7 @@ export const AvatarGroup = forwardRef(