Add truncated props in Badge #2603
Conversation
🦋 Changeset detectedLatest commit: ec08f0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 145 145
Lines 2889 2889
Branches 920 920
=======================================
Hits 2365 2365
+ Misses 520 494 -26
- Partials 4 30 +26 ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
| @@ -24,3 +32,16 @@ export const Primary: StoryObj<BadgeProps> = { | |||
| variant: 'default', | |||
There was a problem hiding this comment.
Primary에서도 배포버전에서 truncated: set object 의 control이 생깁니다. 없앨 예정입니다.
There was a problem hiding this comment.
네네 죄송합니다 제가 요즘 특히 일이 바빠서 주중에는 힘드네요
혹시 언제까지 진행하면 될까요?
There was a problem hiding this comment.
급한건 전혀 아니라 편하게 작업해주셔도 됩니다 🙏
.changeset/funny-eyes-shop.md
Outdated
| '@channel.io/bezier-react': patch | ||
| --- | ||
|
|
||
| Add truncated props in the Badge |
There was a problem hiding this comment.
(minor)
| Add truncated props in the Badge | |
| Add `truncated` props in the Badge |
yangwooseong
added
the
enhancement
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Update icons ([#2593](#2593)) by @ch-builder Added - puzzle.svg ## @channel.io/[email protected] ### Minor Changes - Add `truncated` props in the Badge ([#2603](#2603)) by @nayounsang ## [email protected] ### Patch Changes - Updated dependencies - @channel.io/[email protected] - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Self Checklist
Related Issue
Fixes #2591
Summary
Details
truncatedprops to Badge and added the story of truncated Badge. It supports ellipses in Badge text.widthmust be specified from the outside or on itself. Otherwise, even iftruncatedprops are specified, the length will increase because offlex.Breaking change? (Yes/No)
No
References