Skip to content

Commit 8bf3008

Browse files
codemonkey800codemonkey800
committed
fix type error
1 parent b3a111c commit 8bf3008

File tree

2 files changed

+0
-377
lines changed

2 files changed

+0
-377
lines changed

‎frontend/packages/data-portal/app/components/Filters/BooleanFilter.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export function BooleanFilter({
2424
styles.boolean,
2525
!wrapped && 'whitespace-nowrap',
2626
wrapped && 'max-w-[185px]',
27-
wrapped && styles.booleanWrapped,
2827
)}
2928
>
3029
<InputCheckbox

‎frontend/packages/data-portal/e2e/browseDatasetFilters.test.ts

-376
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { test } from '@chromatic-com/playwright'
22
import { FiltersActor } from 'e2e/pageObjects/filters/filtersActor'
33
import { FiltersPage } from 'e2e/pageObjects/filters/filtersPage'
4-
import { serializeAvailableFiles } from 'e2e/pageObjects/filters/utils'
54

65
import { QueryParams } from 'app/constants/query'
76
import { ObjectShapeType } from 'app/types/shapeTypes'
@@ -74,381 +73,6 @@ test.describe('Browse datasets page filters', () => {
7473
})
7574
})
7675

77-
// TODO: (ehoops) add multi-select filter tests
78-
test.describe('Available files filter', () => {
79-
test.describe(translations.rawFrames, () => {
80-
test('should filter when selecting', async () => {
81-
await filtersPage.goTo(BROWSE_DATASETS_URL)
82-
83-
await filtersActor.addSingleSelectFilter({
84-
label: translations.availableFiles,
85-
value: translations.rawFrames,
86-
})
87-
88-
await filtersActor.expectUrlQueryParamsToBeCorrect({
89-
url: BROWSE_DATASETS_URL,
90-
queryParamsList: [
91-
{
92-
queryParamKey: QueryParams.AvailableFiles,
93-
queryParamValue: translations.rawFrames,
94-
},
95-
],
96-
serialize: serializeAvailableFiles,
97-
})
98-
99-
await filtersPage.waitForTableLoad('browse-datasets')
100-
})
101-
102-
test('should filter when opening URL', async () => {
103-
await filtersActor.goToFilteredUrl({
104-
baseUrl: BROWSE_DATASETS_URL,
105-
queryParamsList: [
106-
{
107-
queryParamKey: QueryParams.AvailableFiles,
108-
queryParamValue: translations.rawFrames,
109-
},
110-
],
111-
serialize: serializeAvailableFiles,
112-
})
113-
})
114-
115-
test('should disable filter when deselecting', async () => {
116-
await filtersActor.goToFilteredUrl({
117-
baseUrl: BROWSE_DATASETS_URL,
118-
queryParamsList: [
119-
{
120-
queryParamKey: QueryParams.AvailableFiles,
121-
queryParamValue: translations.rawFrames,
122-
},
123-
],
124-
serialize: serializeAvailableFiles,
125-
})
126-
127-
await filtersPage.removeFilterOption(translations.rawFrames)
128-
129-
await filtersActor.expectUrlQueryParamsToBeCorrect({
130-
url: BROWSE_DATASETS_URL,
131-
queryParamsList: [
132-
{
133-
queryParamKey: undefined,
134-
queryParamValue: '',
135-
},
136-
],
137-
})
138-
139-
await filtersPage.waitForTableLoad('browse-datasets')
140-
})
141-
})
142-
143-
test.describe(translations.tiltSeries, () => {
144-
test('should filter when selecting', async () => {
145-
await filtersPage.goTo(BROWSE_DATASETS_URL)
146-
147-
await filtersActor.addSingleSelectFilter({
148-
label: translations.availableFiles,
149-
value: translations.tiltSeries,
150-
})
151-
152-
await filtersActor.expectUrlQueryParamsToBeCorrect({
153-
url: BROWSE_DATASETS_URL,
154-
queryParamsList: [
155-
{
156-
queryParamKey: QueryParams.AvailableFiles,
157-
queryParamValue: translations.tiltSeries,
158-
},
159-
],
160-
serialize: serializeAvailableFiles,
161-
})
162-
163-
await filtersPage.waitForTableLoad('browse-datasets')
164-
})
165-
166-
test('should filter when opening URL', async () => {
167-
await filtersActor.goToFilteredUrl({
168-
baseUrl: BROWSE_DATASETS_URL,
169-
queryParamsList: [
170-
{
171-
queryParamKey: QueryParams.AvailableFiles,
172-
queryParamValue: translations.tiltSeries,
173-
},
174-
],
175-
serialize: serializeAvailableFiles,
176-
})
177-
})
178-
179-
test('should disable filter when deselecting', async () => {
180-
await filtersActor.goToFilteredUrl({
181-
baseUrl: BROWSE_DATASETS_URL,
182-
queryParamsList: [
183-
{
184-
queryParamKey: QueryParams.AvailableFiles,
185-
queryParamValue: translations.tiltSeries,
186-
},
187-
],
188-
serialize: serializeAvailableFiles,
189-
})
190-
191-
await filtersPage.removeFilterOption(translations.tiltSeries)
192-
193-
await filtersActor.expectUrlQueryParamsToBeCorrect({
194-
url: BROWSE_DATASETS_URL,
195-
queryParamsList: [
196-
{
197-
queryParamKey: undefined,
198-
queryParamValue: '',
199-
},
200-
],
201-
})
202-
203-
await filtersPage.waitForTableLoad('browse-datasets')
204-
})
205-
})
206-
207-
test.describe(translations.tiltSeriesAlignment, () => {
208-
test('should filter when selecting', async () => {
209-
await filtersPage.goTo(BROWSE_DATASETS_URL)
210-
211-
await filtersActor.addSingleSelectFilter({
212-
label: translations.availableFiles,
213-
value: translations.tiltSeriesAlignment,
214-
})
215-
216-
await filtersActor.expectUrlQueryParamsToBeCorrect({
217-
url: BROWSE_DATASETS_URL,
218-
queryParamsList: [
219-
{
220-
queryParamKey: QueryParams.AvailableFiles,
221-
queryParamValue: translations.tiltSeriesAlignment,
222-
},
223-
],
224-
serialize: serializeAvailableFiles,
225-
})
226-
227-
await filtersPage.waitForTableLoad('browse-datasets')
228-
})
229-
230-
test('should filter when opening URL', async () => {
231-
await filtersActor.goToFilteredUrl({
232-
baseUrl: BROWSE_DATASETS_URL,
233-
queryParamsList: [
234-
{
235-
queryParamKey: QueryParams.AvailableFiles,
236-
queryParamValue: translations.tiltSeriesAlignment,
237-
},
238-
],
239-
serialize: serializeAvailableFiles,
240-
})
241-
})
242-
243-
test('should disable filter when deselecting', async () => {
244-
await filtersActor.goToFilteredUrl({
245-
baseUrl: BROWSE_DATASETS_URL,
246-
queryParamsList: [
247-
{
248-
queryParamKey: QueryParams.AvailableFiles,
249-
queryParamValue: translations.tiltSeriesAlignment,
250-
},
251-
],
252-
serialize: serializeAvailableFiles,
253-
})
254-
255-
await filtersPage.removeFilterOption(translations.tiltSeriesAlignment)
256-
257-
await filtersActor.expectUrlQueryParamsToBeCorrect({
258-
url: BROWSE_DATASETS_URL,
259-
queryParamsList: [
260-
{
261-
queryParamKey: undefined,
262-
queryParamValue: '',
263-
},
264-
],
265-
})
266-
267-
await filtersPage.waitForTableLoad('browse-datasets')
268-
})
269-
})
270-
271-
test.describe(translations.tomograms, () => {
272-
test('should filter when selecting', async () => {
273-
await filtersPage.goTo(BROWSE_DATASETS_URL)
274-
275-
await filtersActor.addSingleSelectFilter({
276-
label: translations.availableFiles,
277-
value: translations.tomograms,
278-
})
279-
280-
await filtersActor.expectUrlQueryParamsToBeCorrect({
281-
url: BROWSE_DATASETS_URL,
282-
queryParamsList: [
283-
{
284-
queryParamKey: QueryParams.AvailableFiles,
285-
queryParamValue: translations.tomograms,
286-
},
287-
],
288-
serialize: serializeAvailableFiles,
289-
})
290-
291-
await filtersPage.waitForTableLoad('browse-datasets')
292-
})
293-
294-
test('should filter when opening URL', async () => {
295-
await filtersActor.goToFilteredUrl({
296-
baseUrl: BROWSE_DATASETS_URL,
297-
queryParamsList: [
298-
{
299-
queryParamKey: QueryParams.AvailableFiles,
300-
queryParamValue: translations.tomograms,
301-
},
302-
],
303-
serialize: serializeAvailableFiles,
304-
})
305-
})
306-
307-
test('should disable filter when deselecting', async () => {
308-
await filtersActor.goToFilteredUrl({
309-
baseUrl: BROWSE_DATASETS_URL,
310-
queryParamsList: [
311-
{
312-
queryParamKey: QueryParams.AvailableFiles,
313-
queryParamValue: translations.tomograms,
314-
},
315-
],
316-
serialize: serializeAvailableFiles,
317-
})
318-
319-
await filtersPage.removeFilterOption(translations.tomograms)
320-
321-
await filtersActor.expectUrlQueryParamsToBeCorrect({
322-
url: BROWSE_DATASETS_URL,
323-
queryParamsList: [
324-
{
325-
queryParamKey: undefined,
326-
queryParamValue: '',
327-
},
328-
],
329-
})
330-
331-
await filtersPage.waitForTableLoad('browse-datasets')
332-
})
333-
})
334-
335-
test.describe('multiple values', () => {
336-
test('should filter multiple values', async () => {
337-
await filtersPage.goTo(BROWSE_DATASETS_URL)
338-
339-
await filtersActor.addSingleSelectFilter({
340-
label: translations.availableFiles,
341-
value: translations.rawFrames,
342-
})
343-
344-
await filtersActor.addSingleSelectFilter({
345-
label: translations.availableFiles,
346-
value: translations.tiltSeries,
347-
})
348-
349-
await filtersActor.addSingleSelectFilter({
350-
label: translations.availableFiles,
351-
value: translations.tiltSeriesAlignment,
352-
})
353-
354-
await filtersActor.addSingleSelectFilter({
355-
label: translations.availableFiles,
356-
value: translations.tomograms,
357-
})
358-
359-
await filtersActor.expectUrlQueryParamsToBeCorrect({
360-
url: BROWSE_DATASETS_URL,
361-
queryParamsList: [
362-
{
363-
queryParamKey: QueryParams.AvailableFiles,
364-
queryParamValue: translations.rawFrames,
365-
},
366-
{
367-
queryParamKey: QueryParams.AvailableFiles,
368-
queryParamValue: translations.tiltSeries,
369-
},
370-
{
371-
queryParamKey: QueryParams.AvailableFiles,
372-
queryParamValue: translations.tiltSeriesAlignment,
373-
},
374-
{
375-
queryParamKey: QueryParams.AvailableFiles,
376-
queryParamValue: translations.tomograms,
377-
},
378-
],
379-
serialize: serializeAvailableFiles,
380-
})
381-
382-
await filtersPage.waitForTableLoad('browse-datasets')
383-
})
384-
test('should filter multiple values when opening URL', async () => {
385-
await filtersActor.goToFilteredUrl({
386-
baseUrl: BROWSE_DATASETS_URL,
387-
queryParamsList: [
388-
{
389-
queryParamKey: QueryParams.AvailableFiles,
390-
queryParamValue: translations.rawFrames,
391-
},
392-
{
393-
queryParamKey: QueryParams.AvailableFiles,
394-
queryParamValue: translations.tiltSeries,
395-
},
396-
{
397-
queryParamKey: QueryParams.AvailableFiles,
398-
queryParamValue: translations.tiltSeriesAlignment,
399-
},
400-
{
401-
queryParamKey: QueryParams.AvailableFiles,
402-
queryParamValue: translations.tomograms,
403-
},
404-
],
405-
serialize: serializeAvailableFiles,
406-
})
407-
})
408-
test('should clear filters', async () => {
409-
await filtersActor.goToFilteredUrl({
410-
baseUrl: BROWSE_DATASETS_URL,
411-
queryParamsList: [
412-
{
413-
queryParamKey: QueryParams.AvailableFiles,
414-
queryParamValue: translations.rawFrames,
415-
},
416-
{
417-
queryParamKey: QueryParams.AvailableFiles,
418-
queryParamValue: translations.tiltSeries,
419-
},
420-
{
421-
queryParamKey: QueryParams.AvailableFiles,
422-
queryParamValue: translations.tiltSeriesAlignment,
423-
},
424-
{
425-
queryParamKey: QueryParams.AvailableFiles,
426-
queryParamValue: translations.tomograms,
427-
},
428-
],
429-
serialize: serializeAvailableFiles,
430-
})
431-
432-
await filtersPage.removeFilterOption(translations.rawFrames)
433-
await filtersPage.removeFilterOption(translations.tiltSeries)
434-
await filtersPage.removeFilterOption(translations.tiltSeriesAlignment)
435-
await filtersPage.removeFilterOption(translations.tomograms)
436-
437-
await filtersActor.expectUrlQueryParamsToBeCorrect({
438-
url: BROWSE_DATASETS_URL,
439-
queryParamsList: [
440-
{
441-
queryParamKey: undefined,
442-
queryParamValue: '',
443-
},
444-
],
445-
})
446-
447-
await filtersPage.waitForTableLoad('browse-datasets')
448-
})
449-
})
450-
})
451-
45276
test.describe('Dataset IDs filter group', () => {
45377
test.describe('Dataset ID filter', () => {
45478
test('should filter when selecting', async () => {

0 commit comments

Comments
 (0)