Skip to content

Commit 3f3b0f5

Browse files
mbarrienczimergebot
authored andcommitted
Make aws-redis-node match internal lib, upgrade default (#146)
Make aws-redis-node match internal lib, upgrade defaultPorting arguments and defaults from CZI internal module library (with the intent of deleting the internal lib module in favor of this one), and upgrading default Redis engine from 5.0.3 to 5.0.5
1 parent 5f1e8fe commit 3f3b0f5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

aws-redis-node/main.tf

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ resource "aws_elasticache_subnet_group" "default" {
1919
resource "aws_elasticache_cluster" "default" {
2020
cluster_id = "${var.resource_name != "" ? var.resource_name : local.name}"
2121
engine = "redis"
22-
engine_version = "3.2.6"
22+
engine_version = "${var.engine_version}"
2323
node_type = "${var.instance_type}"
2424
port = "${var.port}"
2525
num_cache_nodes = 1

aws-redis-node/variables.tf

+4-3
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ variable "subnets" {
2121
variable "availability_zone" {
2222
type = "string"
2323
description = "Availability zone in which this instance should run."
24+
default = null
2425
}
2526

2627
variable "ingress_security_group_ids" {
@@ -42,17 +43,17 @@ variable "port" {
4243
variable "instance_type" {
4344
type = "string"
4445
description = "The type of instance to run. See [supported node types](https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/CacheNodes.SupportedTypes.html)"
45-
default = "cache.m4.large"
46+
default = "cache.m5.large"
4647
}
4748

4849
variable "parameter_group_name" {
49-
default = "default.redis3.2"
50+
default = "default.redis5.0"
5051
}
5152

5253
variable "engine_version" {
5354
type = "string"
5455
description = "The version of Redis to run. See [supported versions](https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/supported-engine-versions.html)"
55-
default = "4.0.10"
56+
default = "5.0.5"
5657
}
5758

5859
variable "apply_immediately" {

0 commit comments

Comments
 (0)