Skip to content

Commit fcb46f1

Browse files
committed
Address PR comments
1 parent d230695 commit fcb46f1

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

aws-acm-certificate/outputs.tf

+3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
output "arn" {
22
value = aws_acm_certificate.cert.arn
3+
description = "AWS ARN of the certificate"
34
}
45

56
output "id" {
67
value = aws_acm_certificate.cert.id
8+
description = "ID of the certificate"
9+
710
}

aws-acm-certificate/variables.tf

+6-5
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,17 @@ variable "cert_subject_alternative_names" {
1010
}
1111

1212
variable "aws_route53_zone_id" {
13-
type = string
13+
type = string
14+
description = "Default Route 53 zone to create validation records in"
1415
}
1516

1617
variable "validation_record_ttl" {
17-
type = string
18-
default = 60
18+
type = string
19+
default = 60
20+
description = "TTL value of DNS validation records"
1921
}
2022

2123
variable tags {
22-
type = map(string)
24+
type = object({ project : string, env : string, service : string, owner : string, managedBy : string })
2325
description = "Tags to apply to certificate"
24-
default = {}
2526
}

0 commit comments

Comments
 (0)