debug: simplify logging with debug mode

- Replace log-level parameter with debug flag in dev options
- Add is_debug_mode method to logger for performance optimization
- Skip verbose operations in non-debug mode
- Remove unnecessary return type annotations

Signed-off-by: ChaoLiu <[email protected]>

Author: chaoliu719

splitpatch/__init__.py

@@ -11,16 +11,24 @@
     handler.setFormatter(formatter)
     logger.addHandler(handler)
 
-def setup_logging(log_level: str = 'INFO') -> None:
+def setup_logging(log_level: bool):
     """Configure package-level logging settings
 
     Args:
-        log_level: Logging level, options: DEBUG, INFO, WARNING, ERROR, CRITICAL
+        log_level: boolean value (True for DEBUG, False for INFO)
     """
-    numeric_level = getattr(logging, log_level.upper(), None)
-    if not isinstance(numeric_level, int):
-        raise ValueError(f"Invalid log level: {log_level}")
-
+    numeric_level = logging.DEBUG if log_level else logging.INFO
     logger.setLevel(numeric_level)
 
+    # Add is_debug_mode method to logger
+    def is_debug_mode() -> bool:
+        """Check if current logging level is DEBUG
+
+        Returns:
+            bool: True if logging level is DEBUG, False otherwise
+        """
+        return logger.getEffectiveLevel() <= logging.DEBUG
+
+    logger.is_debug_mode = is_debug_mode
+
 __all__ = ['logger', 'setup_logging']

splitpatch/cli.py

@@ -43,13 +43,11 @@ def setup_args() -> argparse.Namespace:
 
     # Other parameters
     main_group.add_argument('--dry-run', action='store_true', help='Only show operations to be performed, do not execute')
-    main_group.add_argument('--log-level', type=str, default='INFO',
-                        choices=['DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL'],
-                        help='Logging level (default: INFO)')
     main_group.add_argument('--version', action='version', version=f'%(prog)s {version("splitpatch")}')
 
     # Developer arguments group (hidden from help)
     dev_group = parser.add_argument_group('developer options')
+    dev_group.add_argument('--debug', action='store_true', help=argparse.SUPPRESS)
     dev_group.add_argument('--profile', action='store_true', help=argparse.SUPPRESS)
     dev_group.add_argument('--profile-output', type=str, default='splitpatch.prof',
                         help=argparse.SUPPRESS)
@@ -60,7 +58,7 @@ def setup_args() -> argparse.Namespace:
         parser.error("--outdir is required in non-dry-run mode")
 
     # Configure logging
-    setup_logging(args.log_level)
+    setup_logging(args.debug)
     logger.debug("Starting to process patch files")
 
     # Print argument information
@@ -70,8 +68,9 @@ def setup_args() -> argparse.Namespace:
         logger.info(f"  Output directory: {args.outdir}")
     logger.info(f"  Merge level: {args.level}")
     logger.info(f"  File count threshold: {args.threshold}")
-    logger.info(f"  Log level: {args.log_level}")
     logger.info(f"  Dry run: {'yes' if args.dry_run else 'no'}")
+    if args.debug:
+        logger.info(f"  Debug mode: enabled")
     if args.profile:
         logger.info(f"  Performance profiling: enabled")
         logger.info(f"  Profile output: {args.profile_output}")
@@ -146,7 +145,7 @@ def split_patch(patch: Patch, level: int, threshold: int) -> List[Patch]:
     return root.to_patches()
 
 @profile_method
-def output_patches(patches: List[Patch], outdir: str, dry_run: bool) -> None:
+def output_patches(patches: List[Patch], outdir: str, dry_run: bool):
     """Output processed patches to specified directory
 
     Args:
@@ -174,7 +173,7 @@ def output_patches(patches: List[Patch], outdir: str, dry_run: bool) -> None:
             sys.exit(1)
 
 
-def main() -> None:
+def main():
     try:
         # Parse command line arguments
         args = setup_args()

splitpatch/merge.py

@@ -85,7 +85,7 @@ def _find_module_boundaries(self) -> List[DirNode]:
         """
         module_nodes = []
 
-        def traverse(node: DirNode) -> None:
+        def traverse(node: DirNode):
             if self._is_module_boundary(node):
                 module_nodes.append(node)
             for child in node.dir_nodes:
@@ -108,7 +108,7 @@ def _flatten_nodes(self, node: DirNode):
         logger.debug("Starting flatten operation")
         logger.debug(f"Processing flatten for node {node.path}")
 
-        def process_node(current: DirNode) -> None:
+        def process_node(current: DirNode):
             """Recursively process nodes"""
             # Process all children first (bottom-up)
             for child in current.dir_nodes[:]:
@@ -128,7 +128,7 @@ def _shorten_paths(self):
         """
         logger.debug("Starting path shortening operation")
 
-        def process_node(node: DirNode) -> None:
+        def process_node(node: DirNode):
             # Process all subdirectories first, bottom-up
             for child in node.dir_nodes[:]:
                 process_node(child)
@@ -164,7 +164,7 @@ def _merge_by_level_and_size(self):
         """
         logger.debug("Starting level and size based merge")
 
-        def process_node(node: DirNode) -> None:
+        def process_node(node: DirNode):
             """Recursively process nodes"""
             # Process all children first (bottom-up)
             for child in node.dir_nodes[:]:
@@ -191,7 +191,7 @@ def process_node(node: DirNode) -> None:
         logger.debug("Merge complete")
 
     @profile_method
-    def _merge_to_parent(self, node: DirNode, parent: DirNode) -> None:
+    def _merge_to_parent(self, node: DirNode, parent: DirNode):
         """
         Merge node into parent node
 
@@ -229,7 +229,7 @@ def _merge_to_parent(self, node: DirNode, parent: DirNode) -> None:
         logger.debug(f"Completed merge of node {node.path} into parent {parent.path}")
 
     @profile_method
-    def _verify_tree_integrity(self, node: DirNode) -> None:
+    def _verify_tree_integrity(self, node: DirNode):
         """
         Verify tree integrity, ensure all node parent-child relationships are correct
 
@@ -239,6 +239,9 @@ def _verify_tree_integrity(self, node: DirNode) -> None:
         Raises:
             ValueError: If tree integrity is violated
         """
+        if not logger.is_debug_mode():
+            return
+
         # Verify parent references of all subdirectories
         for child in node.dir_nodes:
             if child.parent != node:

splitpatch/patch.py

@@ -107,7 +107,7 @@ def try_parse(self) -> bool:
             return False
 
     @profile_method
-    def write_patch(self) -> None:
+    def write_patch(self):
         """Write patch to file"""
         # Get output directory path
         output_dir = os.path.dirname(self.path)

splitpatch/tree.py

@@ -68,7 +68,7 @@ def _add_file(self, file_diff: FileDiff) -> FileDiff:
         return file_diff
 
     @profile_method
-    def add_file(self, file_diff: FileDiff) -> None:
+    def add_file(self, file_diff: FileDiff):
         """
         Add file to tree, automatically creating necessary directory structure.
         Note: This method can only be called on the root node.
@@ -169,7 +169,11 @@ def _tree_str(node: DirNode, level: int = 0, prefix: str = "", is_last: bool = T
 
             return "\n".join(result)
 
-        return _tree_str(self)
+        if logger.is_debug_mode():
+            return _tree_str(self)
+
+        # Return simple path and file count information in non-debug mode
+        return f"{self.path} ({len(self.file_changes)} files)"
 
     @profile_method
     def to_patches(self) -> List[Patch]:
@@ -181,7 +185,7 @@ def to_patches(self) -> List[Patch]:
         """
         patches = []
 
-        def _collect_patches(node: DirNode) -> None:
+        def _collect_patches(node: DirNode):
             if node.file_changes:  # Only process nodes with files
                 patch = Patch(f"{node.path}")
                 for file_diff in node.file_changes:

tests/test_cli.py

@@ -42,13 +42,13 @@ def tearDown(self):
             os.remove(self.sample_patch_file)
         os.rmdir(self.temp_dir)
 
-    @patch('sys.argv', ['splitpatch', 'test.patch', '--outdir', 'output', '--log-level', 'DEBUG'])
+    @patch('sys.argv', ['splitpatch', 'test.patch', '--outdir', 'output', '--debug'])
     def test_setup_args(self):
         """Test command line argument parsing"""
         args = setup_args()
         self.assertEqual(args.patch_files, ['test.patch'])
         self.assertEqual(args.outdir, 'output')
-        self.assertEqual(args.log_level, 'DEBUG')
+        self.assertTrue(args.debug)
         self.assertEqual(args.level, 1)  # Default value
         self.assertEqual(args.threshold, 10)  # Default value
         self.assertFalse(args.dry_run)