Skip to content

Commit 2da45ae

Browse files
authored
Merge pull request #3100 from JohnStrunk/fix-ci-docker
Fix failing CI when not tagging a docker image
2 parents e6d93ff + 3b542a4 commit 2da45ae

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/build_docker.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ jobs:
7171
file: ./docker/${{ matrix.image }}/Dockerfile
7272
labels: ${{ steps.meta.outputs.labels }}
7373
platforms: linux/amd64
74-
push: ${{ github.event_name != 'pull_request' }}
74+
# Only push if we've tagged the image in the metadata step
75+
push: ${{ github.event_name != 'pull_request' && steps.meta.outputs.tags != '' }}
7576
tags: ${{ steps.meta.outputs.tags }}
7677
cache-from: type=gha,scope=container-${{ matrix.image }}
7778
cache-to: type=gha,scope=container-${{ matrix.image }},mode=max

0 commit comments

Comments
 (0)