Use Classes to enforce consistent APIs

[MoralCode]

augur/augur/tasks/start_tasks.py

Line 159 in 2c9a5f1

def build_primary_repo_collect_request(session, logger, enabled_phase_names, days_until_collect_again = 15):

These builders are all intended to use the same APIs and conventions, which is why many of them refer to "enabled phases" when they dont need the ability to have disabled phases. All collection request builders must be able to accept a list of 'enabled_phase_names', even if they are not used.

these should maybe be refactored into instances or subclasses so that the convention of matching signatures is more explicit in its purpose and able to be technically enforced.

[MoralCode]

same applies here

augur/augur/tasks/util/collection_util.py

Line 605 in 2c9a5f1

augur_collection_sequence.append(job(repo_git, full_collection))

lists of tasks, such as can be seen in facade_phase (variable facade_core_collection)