Skip to content

Commit 2e8d41e

Browse files
authored
Remove non-portable test for Python module (#27093)
Removes one test case for the Python module, because its not portable and not that useful to test. Since the sign of `char` is implementation defined, comparing it against a signed byte may not work on some platforms [Reviewed by @lydia-duncan]
2 parents 4d0d86e + 1c39ffc commit 2e8d41e

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

test/library/packages/Python/correctness/arrays/arrayTypes.chpl

-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ proc main() {
116116
writeln("Chapel array: ", chplArray2);
117117
}
118118
testNumpy(bool, 'bool', true, false);
119-
testNumpy(c_char, 'byte', 0x60, 0x61, 0x62);
120119
testNumpy(c_schar, 'byte', -1, -2, -3);
121120
testNumpy(c_uchar, 'ubyte', 1, 2, 3);
122121
testNumpy(c_short, 'short', -1, -2, -3);

test/library/packages/Python/correctness/arrays/arrayTypes.good

-10
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,6 @@ Python array: [[ True]
4949
Chapel array: true
5050
false
5151
Testing numpy type (1d array): np.byte
52-
Python array: [96 97 98]
53-
Chapel array: 96 97 98
54-
Testing numpy type (nd array): np.byte
55-
Python array: [[96]
56-
[97]
57-
[98]]
58-
Chapel array: 96
59-
97
60-
98
61-
Testing numpy type (1d array): np.byte
6252
Python array: [-1 -2 -3]
6353
Chapel array: -1 -2 -3
6454
Testing numpy type (nd array): np.byte

0 commit comments

Comments
 (0)