error update when no init, type

Signed-off-by: Ahmad Rezaii <[email protected]>

Author: arezaii

frontend/include/chpl/resolution/resolution-error-classes-list.h

@@ -134,3 +134,4 @@ ERROR_CLASS(UserDiagnosticEmitError, UniqueString, ID)
 WARNING_CLASS(UserDiagnosticEncounterWarning, UniqueString, ID)
 WARNING_CLASS(UserDiagnosticEmitWarning, UniqueString, ID)
 ERROR_CLASS(ValueUsedAsType, const uast::AstNode*, types::QualifiedType)
+ERROR_CLASS(VariableWithoutInitOrType, const uast::AstNode*, ID, chpl::UniqueString)

frontend/lib/resolution/call-init-deinit.cpp

@@ -439,7 +439,7 @@ void CallInitDeinit::resolveDefaultInit(const VarLikeDecl* ast, RV& rv) {
     return;
   }
   if (varType.isUnknownKindOrType()) {
-    context->error(ast, "cannot default initialize variable using generic or unknown type");
+    CHPL_REPORT(context, VariableWithoutInitOrType, ast, ast->id(), ast->name());
     return;
   }
   // check genericity

frontend/lib/resolution/copy-elision.cpp

@@ -102,12 +102,12 @@ struct FindElidedCopies : VarScopeVisitor {
   void handleThrow(const uast::Throw* ast, RV& rv) override;
   void handleYield(const uast::Yield* ast, RV& rv) override;
   void handleTry(const Try* t, RV& rv) override;
-  
-  void handleDisjunction(const AstNode * node, 
+
+  void handleDisjunction(const AstNode * node,
                          VarFrame * currentFrame,
-                         const std::vector<VarFrame*>& frames, 
+                         const std::vector<VarFrame*>& frames,
                          bool total, RV& rv) override;
-  
+
   void handleScope(const AstNode* ast, RV& rv) override;
 };
 
@@ -179,10 +179,10 @@ FindElidedCopies::copyElisionAllowedForTypes(const QualifiedType& lhsType,
                                              RV& rv) {
   if (kindAllowsCopyElision(lhsType.kind()) &&
       kindAllowsCopyElision(rhsType.kind())) {
-    if (lhsType.type() == rhsType.type()) {
-      return true;
-    } else if (lhsType.isUnknown() || rhsType.isUnknown()) {
+    if (lhsType.isUnknown() || rhsType.isUnknown()) {
       return false;
+    } else if (lhsType.type() == rhsType.type()) {
+      return true;
     } else if (isRecordLike(lhsType.type())) {
       // check to see if an there is an init= to initialize
       // lhsType from rhsType but that uses the 'in' intent on the
@@ -428,8 +428,8 @@ static void propagateMentionsAndInits(VarFrame* parentFrame, VarFrame* childFram
 
 
 void FindElidedCopies::handleDisjunction(const AstNode * node,
-                                         VarFrame * currentFrame, 
-                                         const std::vector<VarFrame*>& frames, 
+                                         VarFrame * currentFrame,
+                                         const std::vector<VarFrame*>& frames,
                                          bool total, RV& rv) {
   // if any frame is 'param true' the rest of the frames do not matter
   for (auto frame : frames) {

frontend/lib/resolution/resolution-error-classes-list.cpp

@@ -697,10 +697,10 @@ static void printRejectedCandidates(ErrorWriterBase& wr,
                  !offendingActual->typeExpression()) {
         auto formalKind = badPass.formalType().kind();
         auto actualName = "'" + actualExpr->toIdentifier()->name().str() + "'";
-        wr.message("The actual ", actualName,
+        wr.note(offendingActual->id(), "The actual ", actualName,
                    " expects to be split-initialized because it is declared without a type or initialization expression here:");
         wr.codeForDef(offendingActual);
-        wr.message("The call to '", ci.name() ,"' occurs before any valid initialization points:");
+        wr.note(actualExpr, "The call to '", ci.name() ,"' occurs before any valid initialization points:");
         wr.code(actualExpr, { actualExpr });
         actualPrinted = true;
         wr.message("The call to '", ci.name(), "' cannot initialize ",
@@ -2413,6 +2413,17 @@ void ErrorUseOfLaterVariable::write(ErrorWriterBase& wr) const {
   wr.message("Variables cannot be referenced before they are defined.");
 }
 
+
+void ErrorVariableWithoutInitOrType::write(ErrorWriterBase& wr) const {
+  auto stmt = std::get<const uast::AstNode*>(info_);
+  auto& node = std::get<ID>(info_);
+  auto name = std::get<UniqueString>(info_);
+  wr.heading(kind_, type_, stmt,
+             "variable '", name, "' is declared without an initializer or type.");
+  wr.note(node, "cannot find initialization point to split-init this variable");
+  wr.codeForLocation(node);
+}
+
 void ErrorUserDiagnosticEncounterError::write(ErrorWriterBase& wr) const {
   auto msg = std::get<UniqueString>(info_);
   auto& node = std::get<ID>(info_);