Skip to content

Commit efaa891

Browse files
authored
Quiet some LLVM debug info tests (#27810)
Quiets some LLVM debug info tests that have been causing configs to fail due to slight variances in string printing on various platforms This PR also adds some extra logging to `start_test` when executing `SKIPIF`s [Reviewed by @DanilaFe]
2 parents d1f6551 + bbea227 commit efaa891

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

test/llvm/debugInfo/lldb/SKIPIF

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ if command -v lldb >/dev/null ; then
55
# Sept 10, 2025: skip if lldb does not have python support
66
# required for pretty printing which affects the output of the tests
77
python_path=$(lldb --python-path 2>/dev/null)
8-
if [ -z "$python_path" ]; then
8+
if [[ -z "$python_path" || ! -x "$python_path" ]]; then
99
echo "True"
1010
else
1111
echo "False"

test/llvm/debugInfo/lldb/basicTypes.skipif

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
CHPL_LLVM_VERSION==14
2+
CHPL_LLVM_VERSION==15
3+
CHPL_LLVM_VERSION==16
4+
CHPL_LLVM_VERSION==17
15
# this can remove too much of the debug info
26
COMPOPTS <= --fast
37
# baseline testing has extra call_temps left behind that mess up the good file

util/test/start_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ def test_directory(test, test_type):
299299
skip_test = False
300300
if os.path.isfile("SKIPIF"):
301301
try:
302+
logger.write('[Checking SKIPIF]')
302303
skip_test = process_skipif_output(run_command([test_env, "SKIPIF"]).strip())
303304
# check output and skip if true
304305
if skip_test == "1" or skip_test == "True":

0 commit comments

Comments
 (0)