rowid as id to support dbs without an explicit id column

Author: chapmanjacobd

library/createdb/tabs_add.py

@@ -120,17 +120,17 @@ def tabs_shuffle() -> None:
             f"""
         WITH m as (
             SELECT
-                m.id
+                m.rowid as id
                 , path
                 , frequency
                 , COALESCE(MAX(h.time_played), 0) time_last_played
                 , SUM(CASE WHEN h.done = 1 THEN 1 ELSE 0 END) play_count
                 , hostname
                 , category
             FROM media m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE COALESCE(time_deleted, 0)=0
-            GROUP BY m.id
+            GROUP BY m.rowid
         )
         SELECT
             id

library/mediadb/db_media.py

@@ -451,12 +451,12 @@ def get_dir_media(args, dirs: Collection, include_subdirs=False, limit=2_000) ->
                 , *
                 {', rank' if 'rank' in select_sql else ''}
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
-                and m.id in (select id from {args.table})
+                and m.rowid in (select rowid as id from {args.table})
                 {filter_paths}
                 {" ".join(args.filter_sql)}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT
             {select_sql}
@@ -494,7 +494,7 @@ def get_playlist_media(args, playlist_paths) -> list[dict]:
 
     playlists_subquery = (
         """AND playlists_id in (
-        SELECT id from playlists
+        SELECT rowid as id from playlists
         WHERE path IN ("""
         + ",".join(f":playlist{i}" for i, _ in enumerate(playlist_paths))
         + "))"
@@ -510,12 +510,12 @@ def get_playlist_media(args, playlist_paths) -> list[dict]:
                 , *
                 {', rank' if 'rank' in select_sql else ''}
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
-                and m.id in (select id from {args.table})
+                and m.rowid in (select rowid as id from {args.table})
                 {playlists_subquery}
                 {" ".join(args.filter_sql)}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT
             {select_sql}
@@ -610,11 +610,11 @@ def get_related_media(args, m: dict) -> list[dict]:
                 , *
                 {', rank' if 'rank' in select_sql else ''}
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
                 and path != :path
                 {'' if args.related >= consts.RELATED_NO_FILTER else " ".join(args.filter_sql)}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT
             {select_sql}

library/mediadb/playlists.py

@@ -81,7 +81,7 @@ def playlists() -> None:
             {', sum(m.size) size' if 'size' in m_columns else ''}
             , count(*) count
         from media m
-        JOIN ({query}) p on p.id = m.playlists_id
+        JOIN ({query}) p on p.rowid = m.playlists_id
         group by m.playlists_id, coalesce(p.path, "Playlist-less media")
         order by count, p.path
         """

library/multidb/copy_play_counts.py

@@ -35,7 +35,7 @@ def copy_play_count(args, source_db) -> None:
                 , done
             FROM
                 media m
-            JOIN history h on h.media_id = m.id
+            JOIN history h on h.media_id = m.rowid
             WHERE
                 h.time_played > 0
                 OR

library/utils/sql_utils.py

@@ -244,12 +244,12 @@ def historical_usage(args, freq="monthly", time_column="time_played", hide_delet
                 {', FIRST_VALUE(h.playhead) OVER (PARTITION BY h.media_id ORDER BY h.time_played DESC) playhead' if 'playhead' in h_columns else ''}
                 , *
             FROM media m
-            JOIN history h on h.media_id = m.id
+            JOIN history h on h.media_id = m.rowid
             WHERE 1=1
             {filter_time_played(args)}
             {"AND COALESCE(time_deleted, 0)=0" if hide_deleted else ""}
             {"AND COALESCE(time_deleted, 0)>0" if only_deleted else ""}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT
             {freq_sql} AS {freq_label}

library/utils/sqlgroups.py

@@ -64,7 +64,7 @@ def perf_randomize_using_ids(args):
         limit = 16 * (args.limit or consts.DEFAULT_PLAY_QUEUE)
         where_not_deleted = "where COALESCE(time_deleted,0) = 0" if args.hide_deleted else ""
         args.filter_sql.append(
-            f"and m.id in (select id from media {where_not_deleted} order by random() limit {limit})",
+            f"and m.rowid in (select rowid as id from media {where_not_deleted} order by random() limit {limit})",
         )
 
 
@@ -79,17 +79,17 @@ def media_sql(args) -> tuple[str, dict]:
 
     query = f"""WITH m as (
             SELECT
-                m.id
+                m.rowid as id
                 , SUM(CASE WHEN h.done = 1 THEN 1 ELSE 0 END) play_count
                 , MIN(h.time_played) time_first_played
                 , MAX(h.time_played) time_last_played
                 {', FIRST_VALUE(h.playhead) OVER (PARTITION BY h.media_id ORDER BY h.time_played DESC) playhead' if 'playhead' in h_columns else ''}
                 , *
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
                 {" ".join(args.filter_sql)}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT
             {select_sql}
@@ -127,12 +127,12 @@ def historical_media(args):
                 {', duration' if 'duration' in m_columns else ''}
                 {', subtitle_count' if 'subtitle_count' in m_columns else ''}
             FROM {args.table} m
-            JOIN history h on h.media_id = m.id
+            JOIN history h on h.media_id = m.rowid
             WHERE 1=1
             {sql_utils.filter_time_played(args)}
             {'AND COALESCE(time_deleted, 0)=0' if args.hide_deleted else ""}
             {"AND COALESCE(time_deleted, 0)>0" if args.only_deleted else ""}
-            GROUP BY m.id, m.path
+            GROUP BY m.rowid, m.path
         )
         SELECT *
         FROM m
@@ -163,10 +163,10 @@ def construct_links_query(args, limit) -> tuple[str, dict]:
                 , SUM(CASE WHEN h.done = 1 THEN 1 ELSE 0 END) play_count
                 , time_deleted
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
                 {" ".join(args.filter_sql)}
-            GROUP BY m.id
+            GROUP BY m.rowid
         )
         SELECT
         {', '.join(args.select) if args.select else ''}
@@ -200,10 +200,10 @@ def construct_tabs_query(args) -> tuple[str, dict]:
                 , hostname
                 , category
             FROM {args.table} m
-            LEFT JOIN history h on h.media_id = m.id
+            LEFT JOIN history h on h.media_id = m.rowid
             WHERE 1=1
                 {" ".join(args.filter_sql)}
-            GROUP BY m.id
+            GROUP BY m.rowid
         ), time_valid_tabs as (
             SELECT
                 CASE
@@ -317,7 +317,7 @@ def construct_captions_search_query(args) -> tuple[str, dict]:
     SELECT
         {select_sql}
     FROM c
-    JOIN {m_table} m on m.id = c.media_id
+    JOIN {m_table} m on m.rowid = c.media_id
     WHERE 1=1
         {" ".join(args.aggregate_filter_sql)}
     ORDER BY 1=1
@@ -402,7 +402,7 @@ def construct_download_query(args, dl_status=False) -> tuple[str, dict]:
 
     is_media_playlist = "playlists_id" in m_columns and "id" in pl_columns
     query = f"""select
-            m.id
+            m.rowid as id
             {', m.playlists_id' if "playlists_id" in m_columns else ''}
             , m.path
             {', p.path playlist_path' if is_media_playlist else ''}
@@ -419,7 +419,7 @@ def construct_download_query(args, dl_status=False) -> tuple[str, dict]:
             {', p.extractor_config' if is_media_playlist and 'extractor_config' in pl_columns else ''}
             {', p.extractor_key' if is_media_playlist and 'extractor_key' in pl_columns else ", 'Playlist-less media' as extractor_key"}
         FROM {args.table} m
-        {'LEFT JOIN playlists p on p.id = m.playlists_id' if is_media_playlist else ''}
+        {'LEFT JOIN playlists p on p.rowid = m.playlists_id' if is_media_playlist else ''}
         WHERE 1=1
             {'and COALESCE(m.time_downloaded,0) = 0' if 'time_downloaded' in m_columns and not dl_status else ''}
             {f'and COALESCE(m.download_attempts,0) <= {args.download_retries}' if 'download_attempts' in m_columns and not dl_status else ''}