Merge pull request TheHPXProject#6997 from Sahilll10/fix-move-algorithm-tests

tests: fix self-copy UB in move algorithm tests causing occasional segfault

Author: hkaiser

libs/core/algorithms/tests/unit/algorithms/move.cpp

@@ -33,8 +33,8 @@ void test_move(IteratorTag)
     std::iota(std::begin(c), std::end(c), gen());
     hpx::move(iterator(std::begin(c)), iterator(std::end(c)), std::begin(d));
 
-    //copy contents of d back into c for testing
-    std::copy(std::begin(d), std::end(d), std::begin(d));
+    // copy contents of d back into c for testing
+    std::copy(std::begin(d), std::end(d), std::begin(c));
 
     std::size_t count = 0;
     HPX_TEST(std::equal(std::begin(c), std::end(c), std::begin(d),
@@ -61,8 +61,8 @@ void test_move(ExPolicy policy, IteratorTag)
     hpx::move(
         policy, iterator(std::begin(c)), iterator(std::end(c)), std::begin(d));
 
-    //copy contents of d back into c for testing
-    std::copy(std::begin(d), std::end(d), std::begin(d));
+    // copy contents of d back into c for testing
+    std::copy(std::begin(d), std::end(d), std::begin(c));
 
     std::size_t count = 0;
     HPX_TEST(std::equal(std::begin(c), std::end(c), std::begin(d),

libs/core/algorithms/tests/unit/algorithms/move_sender.cpp

@@ -46,8 +46,8 @@ void test_move_sender(LnPolicy ln_policy, ExPolicy&& ex_policy, IteratorTag)
                       std::begin(d)) |
         hpx::move(ex_policy.on(exec)));
 
-    //copy contents of d back into c for testing
-    std::copy(std::begin(d), std::end(d), std::begin(d));
+    // copy contents of d back into c for testing
+    std::copy(std::begin(d), std::end(d), std::begin(c));
 
     std::size_t count = 0;
     HPX_TEST(std::equal(std::begin(c), std::end(c), std::begin(d),

libs/core/algorithms/tests/unit/container_algorithms/move_range.cpp

@@ -32,8 +32,8 @@ void test_move(IteratorTag)
     std::iota(std::begin(c), std::end(c), std::rand());
     hpx::ranges::move(c, std::begin(d));
 
-    //copy contents of d back into c for testing
-    std::copy(std::begin(d), std::end(d), std::begin(d));
+    // copy contents of d back into c for testing
+    std::copy(std::begin(d), std::end(d), std::begin(c));
 
     std::size_t count = 0;
     HPX_TEST(std::equal(std::begin(c), std::end(c), std::begin(d),
@@ -60,8 +60,8 @@ void test_move(ExPolicy policy, IteratorTag)
     std::iota(std::begin(c), std::end(c), std::rand());
     hpx::ranges::move(policy, c, std::begin(d));
 
-    //copy contents of d back into c for testing
-    std::copy(std::begin(d), std::end(d), std::begin(d));
+    // copy contents of d back into c for testing
+    std::copy(std::begin(d), std::end(d), std::begin(c));
 
     std::size_t count = 0;
     HPX_TEST(std::equal(std::begin(c), std::end(c), std::begin(d),