-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for more compression types #2
Comments
Added support for gzip in e37c44f |
This looks good, with the exception of a few nits I commented on in e37c44f. |
Note: I'm ok with only supporting lzma for python3 if you are. Note also that |
I say hold off on lzma for now then, unless you are strongly compelled
to do so for some reason. Once Python 2 is deprecated in two more
years, we'll turn this on.
…On Thu, 2018-02-22 at 02:38 +0000, Joshua Nelson wrote:
Note: lzma (the compression behind .xz files) is supported natively
only in python 3; to use it in python two a user would have to
install lzma from backports, which involves compiling c code and is
generally a pain.
I'm ok with only supporting lzma for python3 if you are.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Compression other than
bz2
should be supported. We don't need to go overkill, but it's sufficiently easy to compressbytes()
in Python that we may as well support some more. I would suggest maybe gzip, lz4, and an option to disable compression entirely (i.e. for input data that is already compressed).When this feature is implemented, the compatibility level counter should be incremented.
I would make use of function pointers; i.e...
Note that we will need at least one wrapper function to "compress" data for the uncompressed type, and we also might need some for any compression functions that don't support compression levels (or don't do so as the second positional argument).
The text was updated successfully, but these errors were encountered: