Skip to content

Commit 88bd3e7

Browse files
committed
fix(help): show all help options
1 parent ed343f1 commit 88bd3e7

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

keys.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@ import "github.com/charmbracelet/bubbles/v2/key"
55
// ShortHelp returns keybindings to be shown in the mini help view. It's part
66
// of the key.Map interface.
77
func (k keyMap) ShortHelp() []key.Binding {
8-
return []key.Binding{k.Help, k.Quit}
8+
return []key.Binding{k.New, k.Edit, k.Delete, k.Help, k.Quit}
99
}
1010

1111
// FullHelp returns keybindings for the expanded help view. It's part of the
1212
// key.Map interface.
1313
func (k keyMap) FullHelp() [][]key.Binding {
1414
return [][]key.Binding{
15-
{k.Up, k.Down, k.Left, k.Right}, // first column
16-
{k.Help, k.Quit}, // second column
15+
{k.New, k.Edit, k.Delete, k.Enter},
16+
{k.Up, k.Down, k.Left, k.Right},
17+
{k.Back, k.Quit},
1718
}
1819
}
1920

@@ -34,15 +35,15 @@ type keyMap struct {
3435
var keys = keyMap{
3536
New: key.NewBinding(
3637
key.WithKeys("n"),
37-
key.WithHelp("n", "new"),
38+
key.WithHelp("n", "new item"),
3839
),
3940
Edit: key.NewBinding(
4041
key.WithKeys("e"),
41-
key.WithHelp("e", "edit"),
42+
key.WithHelp("e", "edit item"),
4243
),
4344
Delete: key.NewBinding(
4445
key.WithKeys("d"),
45-
key.WithHelp("d", "delete"),
46+
key.WithHelp("d", "delete item"),
4647
),
4748
Up: key.NewBinding(
4849
key.WithKeys("up", "k"),
@@ -62,7 +63,7 @@ var keys = keyMap{
6263
),
6364
Enter: key.NewBinding(
6465
key.WithKeys("enter"),
65-
key.WithHelp("enter", "enter"),
66+
key.WithHelp("enter", "move item"),
6667
),
6768
Help: key.NewBinding(
6869
key.WithKeys("?"),

model.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import (
55
)
66

77
// TODOs
8-
// - clean up textinput & area placeholder text (form could use some razzle dazzle) - use huh for this instead?
98
// - get accurate help menu options (not showing options properly)
109

1110
type Model struct {
@@ -41,7 +40,6 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
4140
m.form = NewForm(msg.title, msg.description)
4241
m.form.index = msg.index
4342
m.form.col = msg.column
44-
// need to trigger what used to happen when a Form was received as msg.
4543
}
4644

4745
if m.modifying {

0 commit comments

Comments
 (0)