fix(ui): stop discarding recently used models over a missing API key

The model picker pruned the stored list of recently used models down to
whatever providers were resolvable at that moment, and saved the result.
Since a provider configured through an environment variable is only
visible when Crush is launched from a shell that exported it, opening the
picker could permanently drop history for providers that were merely
temporarily absent. Unresolvable entries are now skipped when drawing the
list and left in the config.

💘 Generated with Crush

Author: meowgorithm

internal/ui/dialog/models.go

@@ -454,7 +454,12 @@ func (m *Models) setProviderItems() error {
 	if len(recentItems) > 0 {
 		recentGroup := NewModelGroup(t, "Recently used", false)
 
-		var validRecentItems []config.SelectedModel
+		// Recents that cannot be resolved right now are skipped for
+		// display but left in the config. Whether a provider is available
+		// depends on the environment Crush happened to be launched from, so
+		// pruning the stored list here would permanently discard history
+		// over a temporarily missing API key. The list is already bounded
+		// when entries are added.
 		for _, recent := range recentItems {
 			key := modelKey(recent.Provider, recent.Model)
 			item, ok := itemsMap[key]
@@ -466,20 +471,12 @@ func (m *Models) setProviderItems() error {
 			item = NewModelItem(t, item.prov, item.model, m.modelType, true)
 			item.showProvider = true
 
-			validRecentItems = append(validRecentItems, recent)
 			recentGroup.AppendItems(item)
 			if recent.Model == currentModel.Model && recent.Provider == currentModel.Provider {
 				selectedItemID = item.ID()
 			}
 		}
 
-		if len(validRecentItems) != len(recentItems) {
-			// FIXME: Does this need to be here? Is it mutating the config during a read?
-			if err := m.com.Workspace.SetConfigField(config.ScopeGlobal, fmt.Sprintf("recent_models.%s", selectedType), validRecentItems); err != nil {
-				return fmt.Errorf("failed to update recent models: %w", err)
-			}
-		}
-
 		if len(recentGroup.Items) > 0 {
 			groups = append([]ModelGroup{recentGroup}, groups...)
 		}