LSP arguments duplicated

[klonuo]

Describe the bug

I have this setting in crush.json, to use ty lsp server:

"lsp": {
  "python": {
    "command": "ty",
    "args": ["server"]
  }
}

However is fails and from the log it looks like the command argument is passed twice:

{
  "time": "2025-08-30T14:43:13.7255612+02:00",
  "level": "INFO",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/app.(*App).createAndStartLSPClient",
    "file": "/home/runner/work/crush/crush/internal/app/lsp.go",
    "line": 24
  },
  "msg": "Creating LSP client",
  "name": "python",
  "command": "ty",
  "fileTypes": null,
  "args": [
    "server",
    "server"
  ]
},
{
  "time": "2025-08-30T14:43:13.7305185+02:00",
  "level": "INFO",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/llm/agent.NewAgent.func1",
    "file": "/home/runner/work/crush/crush/internal/llm/agent/agent.go",
    "line": 177
  },
  "msg": "Initializing agent tools",
  "agent": "task"
},
{
  "time": "2025-08-30T14:43:13.7502063+02:00",
  "level": "INFO",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/llm/agent.NewAgent.func1",
    "file": "/home/runner/work/crush/crush/internal/llm/agent/agent.go",
    "line": 177
  },
  "msg": "Initializing agent tools",
  "agent": "coder"
},
{
  "time": "2025-08-30T14:43:13.7686134+02:00",
  "level": "ERROR",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/lsp.NewClient.func1",
    "file": "/home/runner/work/crush/crush/internal/lsp/client.go",
    "line": 120
  },
  "msg": "LSP Server",
  "err": "error: unexpected argument 'server' found"
},
{
  "time": "2025-08-30T14:43:13.7686134+02:00",
  "level": "ERROR",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/lsp.NewClient.func1",
    "file": "/home/runner/work/crush/crush/internal/lsp/client.go",
    "line": 120
  },
  "msg": "LSP Server",
  "err": ""
},
{
  "time": "2025-08-30T14:43:13.7686134+02:00",
  "level": "ERROR",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/lsp.NewClient.func1",
    "file": "/home/runner/work/crush/crush/internal/lsp/client.go",
    "line": 120
  },
  "msg": "LSP Server",
  "err": "Usage: ty server"
},
{
  "time": "2025-08-30T14:43:13.7686134+02:00",
  "level": "ERROR",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/lsp.NewClient.func1",
    "file": "/home/runner/work/crush/crush/internal/lsp/client.go",
    "line": 120
  },
  "msg": "LSP Server",
  "err": ""
},
{
  "time": "2025-08-30T14:43:13.7686134+02:00",
  "level": "ERROR",
  "source": {
    "function": "github.com/charmbracelet/crush/internal/lsp.NewClient.func1",
    "file": "/home/runner/work/crush/crush/internal/lsp/client.go",
    "line": 120
  },
  "msg": "LSP Server",
  "err": "For more information, try '--help'."
}

Setup

Please complete the following information along with version numbers, if applicable.

• OS [Windows]
• Shell [pwsh]
• Terminal Emulator [Windows Terminal]
• crush version v0.7.4

[dsully]

I'm seeing this as well.

[kujtimiihoxha]

@klonuo @dsully can you check if this is still an issue with the latest version, we did some underlying changes to the LSP client that could have fixed this.

[klonuo]

Unfortunately same error with 0.9.0

[caarlos0]

this is because its coming from the defaults and apparently merging both?

anyway, you can remove the args from your config to fix the issue for now, and I'll look into it tomorrow.

[klonuo]

It doesn't work w/o arguments, I already tried that.
It's Windows issue, in WSL for example there is no issue

[caarlos0]

it happens on all OSes depending on your global crush configuration.

Looking into it!

[caarlos0]

in the meantime, the workaround is to remove the LSP args from your global crush configuration.